From 370137974526ef9af1f0d3496d17e4232e3babfe Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 11 Dec 2023 01:04:04 -0800 Subject: feat(tvix/eval): nonrecursive deep_force() This commit implements deep_force() nonrecursively, by maintaining an explicit stack rather than using the call stack for recursion. As an added bonus, we don't need to pass around the SharedThunkSet anymore, and can in fact completely eliminate SharedThunkSet. Change-Id: I7c4f59f37834d451a28bf6be317eb0a90eac4ee6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10252 Tested-by: BuildkiteCI Reviewed-by: tazjin Autosubmit: Adam Joseph --- tvix/eval/src/builtins/mod.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tvix/eval/src/builtins/mod.rs') diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index 09b341886c59..5f99704e63c3 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -19,7 +19,7 @@ use crate::warnings::WarningKind; use crate::{ self as tvix_eval, errors::{CatchableErrorKind, ErrorKind}, - value::{CoercionKind, NixAttrs, NixList, NixString, SharedThunkSet, Thunk, Value}, + value::{CoercionKind, NixAttrs, NixList, NixString, Thunk, Value}, }; use self::versions::{VersionPart, VersionPartsIter}; @@ -236,7 +236,7 @@ mod pure_builtins { #[builtin("deepSeq")] async fn builtin_deep_seq(co: GenCo, x: Value, y: Value) -> Result { - generators::request_deep_force(&co, x, SharedThunkSet::default()).await; + generators::request_deep_force(&co, x).await; Ok(y) } @@ -983,7 +983,7 @@ mod pure_builtins { #[builtin("toXML")] async fn builtin_to_xml(co: GenCo, value: Value) -> Result { - let value = generators::request_deep_force(&co, value, SharedThunkSet::default()).await; + let value = generators::request_deep_force(&co, value).await; let mut buf: Vec = vec![]; to_xml::value_to_xml(&mut buf, &value)?; Ok(String::from_utf8(buf)?.into()) -- cgit 1.4.1