From 04f04cfc27f64f42e016a1eba37112f5f2418aa0 Mon Sep 17 00:00:00 2001 From: Ilan Joselevich Date: Sat, 22 Jun 2024 23:23:43 +0300 Subject: refactor(tvix/eval): drop placeholder impls of builtins in glue The builtins `placeholder` and `filterSource` are now implemented in tvix-glue and so we no longer need their placeholder "implementations" in tvix-eval. Change-Id: Ibf161ccf1ad40103e9fbb688e9f6be58e7772af1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11867 Tested-by: BuildkiteCI Reviewed-by: flokli Autosubmit: Ilan Joselevich --- tvix/eval/src/builtins/mod.rs | 16 ---------------- 1 file changed, 16 deletions(-) (limited to 'tvix/eval/src/builtins/mod.rs') diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index 8fc80b2f9c27..96e9985747f5 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -465,15 +465,6 @@ mod pure_builtins { toml::from_str(toml_str.to_str()?).map_err(|err| err.into()) } - #[builtin("filterSource")] - #[allow(non_snake_case)] - async fn builtin_filterSource(_co: GenCo, #[lazy] _e: Value) -> Result { - // TODO: implement for nixpkgs compatibility - Ok(Value::from(CatchableErrorKind::UnimplementedFeature( - "filterSource".into(), - ))) - } - #[builtin("genericClosure")] async fn builtin_generic_closure(co: GenCo, input: Value) -> Result { let attrs = input.to_attrs()?; @@ -1517,13 +1508,6 @@ mod pure_builtins { .into()) } - #[builtin("placeholder")] - async fn builtin_placeholder(co: GenCo, #[lazy] _x: Value) -> Result { - generators::emit_warning_kind(&co, WarningKind::NotImplemented("builtins.placeholder")) - .await; - Ok("".into()) - } - #[builtin("trace")] async fn builtin_trace(co: GenCo, message: Value, value: Value) -> Result { // TODO(grfn): `trace` should be pluggable and capturable, probably via a method on -- cgit 1.4.1