From d25962b9a4d175faaf4ea9e08062036c0a3e0236 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Thu, 25 May 2023 08:34:00 +0300 Subject: refactor(tvix/eval): stop borrowing &mut self This does undo cl/8571. Change-Id: Ib14b4e7404f906e346304b6113860ae811afc94a Reviewed-on: https://cl.tvl.fyi/c/depot/+/8631 Tested-by: BuildkiteCI Reviewed-by: tazjin Autosubmit: flokli --- tvix/cli/src/nix_compat.rs | 8 ++++---- tvix/cli/src/tvix_io.rs | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'tvix/cli') diff --git a/tvix/cli/src/nix_compat.rs b/tvix/cli/src/nix_compat.rs index 0da3aeb212..bda2389838 100644 --- a/tvix/cli/src/nix_compat.rs +++ b/tvix/cli/src/nix_compat.rs @@ -34,7 +34,7 @@ impl EvalIO for NixCompatIO { } // Pass path imports through to `nix-store --add` - fn import_path(&mut self, path: &Path) -> Result { + fn import_path(&self, path: &Path) -> Result { let path = path.to_owned(); if let Some(path) = self .import_cache @@ -56,7 +56,7 @@ impl EvalIO for NixCompatIO { } // Pass the rest of the functions through to `Self::underlying` - fn path_exists(&mut self, path: &Path) -> Result { + fn path_exists(&self, path: &Path) -> Result { if path.starts_with("/__corepkgs__") { return Ok(true); } @@ -64,7 +64,7 @@ impl EvalIO for NixCompatIO { self.underlying.path_exists(path) } - fn read_to_string(&mut self, path: &Path) -> Result { + fn read_to_string(&self, path: &Path) -> Result { // Bundled version of corepkgs/fetchurl.nix. This workaround // is similar to what cppnix does for passing the path // through. @@ -78,7 +78,7 @@ impl EvalIO for NixCompatIO { self.underlying.read_to_string(path) } - fn read_dir(&mut self, path: &Path) -> Result, io::Error> { + fn read_dir(&self, path: &Path) -> Result, io::Error> { self.underlying.read_dir(path) } } diff --git a/tvix/cli/src/tvix_io.rs b/tvix/cli/src/tvix_io.rs index cc32786055..8ca660f87b 100644 --- a/tvix/cli/src/tvix_io.rs +++ b/tvix/cli/src/tvix_io.rs @@ -39,7 +39,7 @@ impl EvalIO for TvixIO { self.actual.store_dir() } - fn import_path(&mut self, path: &Path) -> Result { + fn import_path(&self, path: &Path) -> Result { let imported_path = self.actual.import_path(path)?; self.known_paths .borrow_mut() @@ -48,7 +48,7 @@ impl EvalIO for TvixIO { Ok(imported_path) } - fn path_exists(&mut self, path: &Path) -> Result { + fn path_exists(&self, path: &Path) -> Result { if path.starts_with("/__corepkgs__") { return Ok(true); } @@ -56,7 +56,7 @@ impl EvalIO for TvixIO { self.actual.path_exists(path) } - fn read_to_string(&mut self, path: &Path) -> Result { + fn read_to_string(&self, path: &Path) -> Result { // Bundled version of corepkgs/fetchurl.nix. The counterpart // of this happens in `main`, where the `nix_path` of the // evaluation has `nix=/__corepkgs__` added to it. @@ -73,7 +73,7 @@ impl EvalIO for TvixIO { self.actual.read_to_string(path) } - fn read_dir(&mut self, path: &Path) -> Result, io::Error> { + fn read_dir(&self, path: &Path) -> Result, io::Error> { self.actual.read_dir(path) } } -- cgit 1.4.1