From 11771a06aed715b5e7a921b879e9415ccad48711 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sun, 21 May 2023 11:17:34 +0300 Subject: refactor(tvix/eval): use &Path instead of PathBuf This allows getting rid of some clones in eval/src/vm/generators.rs. Change-Id: I330390307d3bcfeef19c98954c753ee55b1ccee3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8604 Autosubmit: flokli Tested-by: BuildkiteCI Reviewed-by: tazjin --- tvix/cli/src/nix_compat.rs | 6 +++--- tvix/cli/src/tvix_io.rs | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'tvix/cli') diff --git a/tvix/cli/src/nix_compat.rs b/tvix/cli/src/nix_compat.rs index ce352f0a964c..b322886c9e20 100644 --- a/tvix/cli/src/nix_compat.rs +++ b/tvix/cli/src/nix_compat.rs @@ -47,7 +47,7 @@ impl EvalIO for NixCompatIO { } // Pass the rest of the functions through to `Self::underlying` - fn path_exists(&mut self, path: PathBuf) -> Result { + fn path_exists(&mut self, path: &Path) -> Result { if path.starts_with("/__corepkgs__") { return Ok(true); } @@ -55,7 +55,7 @@ impl EvalIO for NixCompatIO { self.underlying.path_exists(path) } - fn read_to_string(&mut self, path: PathBuf) -> Result { + fn read_to_string(&mut self, path: &Path) -> Result { // Bundled version of corepkgs/fetchurl.nix. This workaround // is similar to what cppnix does for passing the path // through. @@ -69,7 +69,7 @@ impl EvalIO for NixCompatIO { self.underlying.read_to_string(path) } - fn read_dir(&mut self, path: PathBuf) -> Result, io::Error> { + fn read_dir(&mut self, path: &Path) -> Result, io::Error> { self.underlying.read_dir(path) } } diff --git a/tvix/cli/src/tvix_io.rs b/tvix/cli/src/tvix_io.rs index 5a3f5b0e7a1a..cc3278605572 100644 --- a/tvix/cli/src/tvix_io.rs +++ b/tvix/cli/src/tvix_io.rs @@ -48,7 +48,7 @@ impl EvalIO for TvixIO { Ok(imported_path) } - fn path_exists(&mut self, path: PathBuf) -> Result { + fn path_exists(&mut self, path: &Path) -> Result { if path.starts_with("/__corepkgs__") { return Ok(true); } @@ -56,7 +56,7 @@ impl EvalIO for TvixIO { self.actual.path_exists(path) } - fn read_to_string(&mut self, path: PathBuf) -> Result { + fn read_to_string(&mut self, path: &Path) -> Result { // Bundled version of corepkgs/fetchurl.nix. The counterpart // of this happens in `main`, where the `nix_path` of the // evaluation has `nix=/__corepkgs__` added to it. @@ -73,7 +73,7 @@ impl EvalIO for TvixIO { self.actual.read_to_string(path) } - fn read_dir(&mut self, path: PathBuf) -> Result, io::Error> { + fn read_dir(&mut self, path: &Path) -> Result, io::Error> { self.actual.read_dir(path) } } -- cgit 1.4.1