From b7ab6c08561143df9ab6eb2255a74c37719f48f2 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sun, 21 May 2023 11:00:49 +0300 Subject: refactor(tvix/eval/io): use io::Error instead of tvix_eval errors We didn't return anything useful other than ErrorKind::IO anyways. We can use io::ErrorKind::Unsupported for DummyIO. Fixes b/271. Change-Id: Icb231e9b38168e8b6fa473bfa405d160357b317f Reviewed-on: https://cl.tvl.fyi/c/depot/+/8602 Autosubmit: flokli Tested-by: BuildkiteCI Reviewed-by: tazjin --- tvix/cli/src/tvix_io.rs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'tvix/cli/src/tvix_io.rs') diff --git a/tvix/cli/src/tvix_io.rs b/tvix/cli/src/tvix_io.rs index 401b8a5f48da..5a3f5b0e7a1a 100644 --- a/tvix/cli/src/tvix_io.rs +++ b/tvix/cli/src/tvix_io.rs @@ -11,9 +11,10 @@ use crate::KnownPaths; use smol_str::SmolStr; use std::cell::RefCell; +use std::io; use std::path::{Path, PathBuf}; use std::rc::Rc; -use tvix_eval::{ErrorKind, EvalIO, FileType}; +use tvix_eval::{EvalIO, FileType}; pub(crate) struct TvixIO { /// Ingested paths must be reported to this known paths tracker @@ -38,7 +39,7 @@ impl EvalIO for TvixIO { self.actual.store_dir() } - fn import_path(&mut self, path: &Path) -> Result { + fn import_path(&mut self, path: &Path) -> Result { let imported_path = self.actual.import_path(path)?; self.known_paths .borrow_mut() @@ -47,7 +48,7 @@ impl EvalIO for TvixIO { Ok(imported_path) } - fn path_exists(&mut self, path: PathBuf) -> Result { + fn path_exists(&mut self, path: PathBuf) -> Result { if path.starts_with("/__corepkgs__") { return Ok(true); } @@ -55,7 +56,7 @@ impl EvalIO for TvixIO { self.actual.path_exists(path) } - fn read_to_string(&mut self, path: PathBuf) -> Result { + fn read_to_string(&mut self, path: PathBuf) -> Result { // Bundled version of corepkgs/fetchurl.nix. The counterpart // of this happens in `main`, where the `nix_path` of the // evaluation has `nix=/__corepkgs__` added to it. @@ -72,7 +73,7 @@ impl EvalIO for TvixIO { self.actual.read_to_string(path) } - fn read_dir(&mut self, path: PathBuf) -> Result, ErrorKind> { + fn read_dir(&mut self, path: PathBuf) -> Result, io::Error> { self.actual.read_dir(path) } } -- cgit 1.4.1