From b8f92a6d535af09c24ac887855eb230ca25af1ed Mon Sep 17 00:00:00 2001 From: Aspen Smith Date: Sun, 28 Jul 2024 12:11:41 -0400 Subject: feat(tvix/eval): Forbid Hash{Map,Set}, use Fx instead Per https://nnethercote.github.io/perf-book/hashing.html, we have basically no reason to use the default hasher over a faster, non-DoS-resistant hasher. This gives a nice perf boost basically for free: hello outpath time: [704.76 ms 714.91 ms 725.63 ms] change: [-7.2391% -6.1018% -4.9189%] (p = 0.00 < 0.05) Performance has improved. Change-Id: If5587f444ed3af69f8af4eead6af3ea303b4ae68 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12046 Tested-by: BuildkiteCI Reviewed-by: flokli Reviewed-by: Ilan Joselevich Autosubmit: aspen --- tvix/cli/Cargo.toml | 1 + 1 file changed, 1 insertion(+) (limited to 'tvix/cli/Cargo.toml') diff --git a/tvix/cli/Cargo.toml b/tvix/cli/Cargo.toml index abbb7e6c2bd0..7f93da85d47a 100644 --- a/tvix/cli/Cargo.toml +++ b/tvix/cli/Cargo.toml @@ -26,6 +26,7 @@ thiserror = "1.0.38" tokio = "1.28.0" tracing = "0.1.40" tracing-indicatif = "0.3.6" +rustc-hash = "2.0.0" [dependencies.wu-manber] git = "https://github.com/tvlfyi/wu-manber.git" -- cgit 1.4.1