From 34a1ff291a0444b3e56f96e6cc72899ab818a2f7 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 17 Feb 2024 13:18:10 +0700 Subject: feat(tvix/castore/fs): make allow_other configurable Also add a cli argument to the `tvix-store` binary. Change-Id: Id07d7fedb60d6060543b195f3a810a46137f9ad5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10945 Tested-by: BuildkiteCI Autosubmit: flokli Reviewed-by: tazjin --- tvix/castore/src/fs/fuse.rs | 9 +++++++-- tvix/castore/src/fs/tests.rs | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) (limited to 'tvix/castore/src') diff --git a/tvix/castore/src/fs/fuse.rs b/tvix/castore/src/fs/fuse.rs index 1dce43915905..cd50618ff5bc 100644 --- a/tvix/castore/src/fs/fuse.rs +++ b/tvix/castore/src/fs/fuse.rs @@ -53,7 +53,12 @@ pub struct FuseDaemon { impl FuseDaemon { #[instrument(skip(fs, mountpoint), fields(mountpoint=?mountpoint), err)] - pub fn new(fs: FS, mountpoint: P, threads: usize) -> Result + pub fn new( + fs: FS, + mountpoint: P, + threads: usize, + allow_other: bool, + ) -> Result where FS: FileSystem + Sync + Send + 'static, P: AsRef + std::fmt::Debug, @@ -64,7 +69,7 @@ impl FuseDaemon { .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?; #[cfg(target_os = "linux")] - session.set_allow_other(false); + session.set_allow_other(allow_other); session .mount() .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?; diff --git a/tvix/castore/src/fs/tests.rs b/tvix/castore/src/fs/tests.rs index 2f27c3c1c8e4..924454caa6dd 100644 --- a/tvix/castore/src/fs/tests.rs +++ b/tvix/castore/src/fs/tests.rs @@ -51,7 +51,7 @@ where Arc::new(root_nodes), list_root, ); - FuseDaemon::new(Arc::new(fs), mountpoint.as_ref(), 4) + FuseDaemon::new(Arc::new(fs), mountpoint.as_ref(), 4, false) } async fn populate_blob_a( -- cgit 1.4.1