From 5ec93b57e6a263eef91ee583aba9f04581e4a66b Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Fri, 16 Aug 2024 17:32:20 +0300 Subject: refactor(tvix/castore): add PathComponent type for checked components This encodes a verified component on the type level. Internally, it contains a bytes::Bytes. The castore Path/PathBuf component() and file_name() methods now return this type, the old ones returning bytes were renamed to component_bytes() and component_file_name() respectively. We can drop the directory_reject_invalid_name test - it's not possible anymore to pass an invalid name to Directories::add. Invalid names in the Directory proto are still being tested to be rejected in the validate_invalid_names tests. Change-Id: Ide4d16415dfd50b7e2d7e0c36d42a3bbeeb9b6c5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12217 Autosubmit: flokli Reviewed-by: Connor Brewster Tested-by: BuildkiteCI --- tvix/build/src/proto/mod.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tvix/build/src/proto') diff --git a/tvix/build/src/proto/mod.rs b/tvix/build/src/proto/mod.rs index d3b325bd3e62..b36049d05b9d 100644 --- a/tvix/build/src/proto/mod.rs +++ b/tvix/build/src/proto/mod.rs @@ -125,7 +125,7 @@ impl BuildRequest { pub fn validate(&self) -> Result<(), ValidateBuildRequestError> { // validate names. Make sure they're sorted - let mut last_name = bytes::Bytes::new(); + let mut last_name: bytes::Bytes = "".into(); for (i, node) in self.inputs.iter().enumerate() { // TODO(flokli): store result somewhere let (name, _node) = node @@ -133,10 +133,10 @@ impl BuildRequest { .into_name_and_node() .map_err(|e| ValidateBuildRequestError::InvalidInputNode(i, e))?; - if name <= last_name { + if name.as_ref() <= last_name.as_ref() { return Err(ValidateBuildRequestError::InputNodesNotSorted); } else { - last_name = name + last_name = name.into() } } -- cgit 1.4.1