From d7ccf351494873b7e45ba450019c5462ef860aeb Mon Sep 17 00:00:00 2001
From: Vincent Ambo <tazjin@google.com>
Date: Tue, 5 Nov 2019 14:03:48 +0000
Subject: feat(builder): Support 'arm64' meta-package

Specifying this meta-package toggles support for ARM64 images, for
example:

    # Pull a default x86_64 image
    docker pull nixery.dev/hello

    # Pull an ARM64 image
    docker pull nixery.dev/arm64/hello
---
 tools/nixery/server/builder/builder.go | 41 ++++++++++++++++++++++++----------
 1 file changed, 29 insertions(+), 12 deletions(-)

(limited to 'tools')

diff --git a/tools/nixery/server/builder/builder.go b/tools/nixery/server/builder/builder.go
index c726b137fc33..57b94090911e 100644
--- a/tools/nixery/server/builder/builder.go
+++ b/tools/nixery/server/builder/builder.go
@@ -67,7 +67,7 @@ type Architecture struct {
 }
 
 var amd64 = Architecture{"x86_64-linux", "amd64"}
-var arm = Architecture{"aarch64-linux", "arm64"}
+var arm64 = Architecture{"aarch64-linux", "arm64"}
 
 // Image represents the information necessary for building a container image.
 // This can be either a list of package names (corresponding to keys in the
@@ -106,7 +106,7 @@ type BuildResult struct {
 // only the order of requested packages has changed.
 func ImageFromName(name string, tag string) Image {
 	pkgs := strings.Split(name, "/")
-	expanded := convenienceNames(pkgs)
+	arch, expanded := metaPackages(pkgs)
 	expanded = append(expanded, "cacert", "iana-etc")
 
 	sort.Strings(pkgs)
@@ -116,7 +116,7 @@ func ImageFromName(name string, tag string) Image {
 		Name:     strings.Join(pkgs, "/"),
 		Tag:      tag,
 		Packages: expanded,
-		Arch:     &amd64,
+		Arch:     arch,
 	}
 }
 
@@ -136,22 +136,39 @@ type ImageResult struct {
 	} `json:"symlinkLayer"`
 }
 
-// convenienceNames expands convenience package names defined by Nixery which
-// let users include commonly required sets of tools in a container quickly.
+// metaPackages expands package names defined by Nixery which either
+// include sets of packages or trigger certain image-building
+// behaviour.
 //
-// Convenience names must be specified as the first package in an image.
+// Meta-packages must be specified as the first packages in an image
+// name.
 //
-// Currently defined convenience names are:
+// Currently defined meta-packages are:
 //
 // * `shell`: Includes bash, coreutils and other common command-line tools
-func convenienceNames(packages []string) []string {
-	shellPackages := []string{"bashInteractive", "coreutils", "moreutils", "nano"}
+// * `arm64`: Causes Nixery to build images for the ARM64 architecture
+func metaPackages(packages []string) (*Architecture, []string) {
+	arch := &amd64
+	var metapkgs []string
+	for idx, p := range packages {
+		if p == "shell" || p == "arm64" {
+			metapkgs = append(metapkgs, p)
+		} else {
+			packages = packages[idx:]
+			break
+		}
+	}
 
-	if packages[0] == "shell" {
-		return append(packages[1:], shellPackages...)
+	for _, p := range metapkgs {
+		switch p {
+		case "shell":
+			packages = append(packages, "bashInteractive", "coreutils", "moreutils", "nano")
+		case "arm64":
+			arch = &arm64
+		}
 	}
 
-	return packages
+	return arch, packages
 }
 
 // logNix logs each output line from Nix. It runs in a goroutine per
-- 
cgit 1.4.1