From 8b06566d43275201e6f82284e2d334202ec2ae45 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Fri, 16 Feb 2024 17:41:44 +0700 Subject: fix(third_party/nixpkgs/crate2nix): reintroduce tests in debug patch This is was dropped accidentially, but we actually want to run tests in debug mode, to check for overflows. Change-Id: Ic0cf2d4a263bfd71f3453ed335d8be9dacd945e8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10932 Autosubmit: flokli Tested-by: BuildkiteCI Reviewed-by: tazjin --- third_party/overlays/patches/crate2nix-tests-debug.patch | 12 ++++++++++++ third_party/overlays/tvl.nix | 5 ++++- 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 third_party/overlays/patches/crate2nix-tests-debug.patch (limited to 'third_party') diff --git a/third_party/overlays/patches/crate2nix-tests-debug.patch b/third_party/overlays/patches/crate2nix-tests-debug.patch new file mode 100644 index 0000000000..384178c805 --- /dev/null +++ b/third_party/overlays/patches/crate2nix-tests-debug.patch @@ -0,0 +1,12 @@ +diff --git a/templates/nix/crate2nix/default.nix b/templates/nix/crate2nix/default.nix +index 4eefda8..d064118 100644 +--- a/templates/nix/crate2nix/default.nix ++++ b/templates/nix/crate2nix/default.nix +@@ -111,6 +111,7 @@ rec { + ( + _: { + buildTests = true; ++ release = false; + } + ); + # If the user hasn't set any pre/post commands, we don't want to diff --git a/third_party/overlays/tvl.nix b/third_party/overlays/tvl.nix index fd6b35163e..3a46646317 100644 --- a/third_party/overlays/tvl.nix +++ b/third_party/overlays/tvl.nix @@ -94,7 +94,10 @@ depot.nix.readTree.drvTargets { hash = "sha256-JTMe8GViCQt51WUiaaoIPmWtwEeeYrl6pBxo2DNuKig="; }; - patches = [ ./patches/crate2nix-run-tests-in-build-source.patch ]; + patches = [ + ./patches/crate2nix-tests-debug.patch + ./patches/crate2nix-run-tests-in-build-source.patch + ]; sourceRoot = "${src.name}/crate2nix"; -- cgit 1.4.1