From 54a575077006494c83ee043ebc21e09c4fe8b596 Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Sun, 19 Jul 2020 00:36:22 -0400 Subject: test(3p/nix): Add property tests for attribute set Add a set of property tests for the attribute set (Bindings) class checking that the Merge operation satisfies the monoid laws. This will hopefully become useful to make sure we're not breaking the language semantics as we work towards optimizing or replacing the implementation, but also serves as a test bed for adding rapidcheck-based property tests to the codebase. Change-Id: I1b4b7b6503d08d80c1c5a8f9408fd4b787d00e8e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1283 Reviewed-by: isomer Tested-by: BuildkiteCI --- third_party/nix/CMakeLists.txt | 1 + third_party/nix/default.nix | 6 +- third_party/nix/src/tests/CMakeLists.txt | 10 ++ third_party/nix/src/tests/attr-set.cc | 159 +++++++++++++++++++++++++++++++ 4 files changed, 175 insertions(+), 1 deletion(-) create mode 100644 third_party/nix/src/tests/attr-set.cc (limited to 'third_party') diff --git a/third_party/nix/CMakeLists.txt b/third_party/nix/CMakeLists.txt index f796ccdee4..71651a9b11 100644 --- a/third_party/nix/CMakeLists.txt +++ b/third_party/nix/CMakeLists.txt @@ -43,6 +43,7 @@ option(PACKAGE_TESTS "Build the tests" ON) if (PACKAGE_TESTS) enable_testing() find_package(GTest) + find_package(rapidcheck) include(GoogleTest) endif() diff --git a/third_party/nix/default.nix b/third_party/nix/default.nix index c4a3050169..54e77ec50d 100644 --- a/third_party/nix/default.nix +++ b/third_party/nix/default.nix @@ -55,7 +55,6 @@ in pkgs.llvmPackages.libcxxStdenv.mkDerivation { flex glog grpc - gtest libseccomp libsodium openssl @@ -67,6 +66,11 @@ in pkgs.llvmPackages.libcxxStdenv.mkDerivation { doCheck = false; doInstallCheck = true; + installCheckInputs = with pkgs; [ + gtest + rapidcheck + ]; + propagatedBuildInputs = with pkgs; [ boost largeBoehm diff --git a/third_party/nix/src/tests/CMakeLists.txt b/third_party/nix/src/tests/CMakeLists.txt index 81ccf95b78..b21b194630 100644 --- a/third_party/nix/src/tests/CMakeLists.txt +++ b/third_party/nix/src/tests/CMakeLists.txt @@ -1,6 +1,16 @@ # -*- mode: cmake; -*- include_directories(${PROJECT_BINARY_DIR}) # for 'generated/' +add_executable(attr-set attr-set.cc) +target_link_libraries(attr-set + nixexpr + rapidcheck + rapidcheck_gtest + GTest::gtest_main +) + +gtest_discover_tests(attr-set) + add_executable(value-to-json value-to-json.cc) target_link_libraries(value-to-json nixexpr diff --git a/third_party/nix/src/tests/attr-set.cc b/third_party/nix/src/tests/attr-set.cc new file mode 100644 index 0000000000..e8ad86664b --- /dev/null +++ b/third_party/nix/src/tests/attr-set.cc @@ -0,0 +1,159 @@ +#include "libexpr/attr-set.hh" + +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "libexpr/eval.hh" +#include "libexpr/nixexpr.hh" +#include "libexpr/symbol-table.hh" +#include "libexpr/value.hh" +#include "tests/dummy-store.hh" + +static nix::SymbolTable* symbol_table; + +namespace rc { +using nix::Pos; +using nix::Value; + +// TODO(grfn): These arbitrary implementations should be pulled out to a util +// file sooner rather than later + +template <> +struct Arbitrary { + static Gen arbitrary() { + return gen::map(gen::arbitrary(), + [](std::string s) { return symbol_table->Create(s); }); + } +}; + +template <> +struct Arbitrary { + static Gen arbitrary() { + return gen::build(gen::construct(), + // TODO(grfn) generalize to more types + gen::set(&Value::type, gen::just(nix::ValueType::tInt)), + gen::set(&Value::integer, gen::arbitrary())); + } +}; + +template <> +struct Arbitrary { + static Gen arbitrary() { + return gen::apply( + [](nix::ValueType typ, int i) { + auto ret = new (GC) Value(); + ret->type = typ; + ret->integer = i; + return ret; + }, + gen::just(nix::ValueType::tInt), gen::arbitrary()); + } +}; + +template <> +struct Arbitrary { + static Gen arbitrary() { + return gen::construct(gen::arbitrary(), + gen::arbitrary(), + gen::arbitrary()); + } +}; + +template <> +struct Arbitrary { + static Gen arbitrary() { + return gen::apply( + [](unsigned int line, unsigned int column) { + return new (GC) Pos({}, line, column); + }, + gen::arbitrary(), gen::arbitrary()); + } +}; + +template <> +struct Arbitrary { + static Gen arbitrary() { + return gen::construct(gen::arbitrary(), + gen::arbitrary(), + gen::arbitrary()); + } +}; + +template <> +struct Arbitrary { + static Gen arbitrary() { + return gen::map(gen::arbitrary>(), [](auto attrs) { + nix::Bindings res; + for (const auto& attr : attrs) { + res.push_back(attr); + } + return res; + }); + } +}; + +} // namespace rc + +namespace nix { + +using nix::tests::DummyStore; + +class AttrSetTest : public ::testing::Test { + protected: + EvalState* eval_state_; + void SetUp() override { + nix::initGC(); + auto store = std::make_shared(); + eval_state_ = new EvalState({"."}, ref(store)); + symbol_table = &eval_state_->symbols; + } + + void assert_bindings_equal(nix::Bindings& lhs, nix::Bindings& rhs) { + Value lhs_val; + Value rhs_val; + lhs_val.type = rhs_val.type = ValueType::tAttrs; + lhs_val.attrs = &lhs; + rhs_val.attrs = &lhs; + + RC_ASSERT(eval_state_->eqValues(lhs_val, rhs_val)); + } +}; + +class AttrSetMonoidTest : public AttrSetTest {}; + +RC_GTEST_FIXTURE_PROP(AttrSetMonoidTest, mergeLeftIdentity, + (nix::Bindings && bindings)) { + auto empty_bindings = nix::Bindings::NewGC(); + auto result = *Bindings::Merge(*empty_bindings, bindings); + assert_bindings_equal(result, bindings); +} + +RC_GTEST_FIXTURE_PROP(AttrSetMonoidTest, mergeRightIdentity, + (nix::Bindings && bindings)) { + auto empty_bindings = nix::Bindings::NewGC(); + auto result = *Bindings::Merge(bindings, *empty_bindings); + assert_bindings_equal(result, bindings); +} + +RC_GTEST_FIXTURE_PROP(AttrSetMonoidTest, mergeAssociative, + (nix::Bindings && bindings_1, nix::Bindings&& bindings_2, + nix::Bindings&& bindings_3)) { + assert_bindings_equal( + *Bindings::Merge(bindings_1, *Bindings::Merge(bindings_2, bindings_3)), + *Bindings::Merge(*Bindings::Merge(bindings_1, bindings_2), bindings_3)); +} + +} // namespace nix -- cgit 1.4.1