From 8893c30114822148c396eb1f116cd7e1a6f3f095 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Fri, 21 Aug 2020 01:00:50 +0100 Subject: chore(tvix): Add TODO comment for std::ostream in buildDerivation Change-Id: I1e3b6abd4606d86f00ddaa8e2a1809f51e27126d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1823 Tested-by: BuildkiteCI Reviewed-by: glittershark --- third_party/nix/src/libstore/store-api.hh | 1 + 1 file changed, 1 insertion(+) (limited to 'third_party/nix') diff --git a/third_party/nix/src/libstore/store-api.hh b/third_party/nix/src/libstore/store-api.hh index 91dd54cfe5f1..76c757bd6939 100644 --- a/third_party/nix/src/libstore/store-api.hh +++ b/third_party/nix/src/libstore/store-api.hh @@ -467,6 +467,7 @@ class Store : public std::enable_shared_from_this, public Config { /* Build a single non-materialized derivation (i.e. not from an on-disk .drv file). Note that ‘drvPath’ is only used for informational purposes. */ + // TODO(tazjin): Thread std::ostream through here, too. virtual BuildResult buildDerivation(const Path& drvPath, const BasicDerivation& drv, BuildMode buildMode) = 0; -- cgit 1.4.1