From 72e61aa584c3e3bbafbdc539959a2db8e0f123ef Mon Sep 17 00:00:00 2001 From: Kane York Date: Thu, 13 Aug 2020 15:18:40 -0700 Subject: refactor(tvix): completely remove boehm gc We have decided that leaking memory is a better fate than random, non-debuggable memory corruption. Future CLs will begin changing various fields to std::unique_ptr and std::shared_ptr. It turns out that disabling the GC does not have disasterous impact. The Nix evaluator only runs on the client CLI, never in any long- running process. Even the REPL does not leak too badly under this change, because it uses one EvalState for the duration of the REPL. Building an explicitly tracing garbage collector is likely in the future of this project, but that giant amount of work cannot be done under a nix evaluator that is constantly crashing. We need to restore development velocity here, and this is the best way we've figured out to do it. Change-Id: I2fcda8fcee853c15a9a5e22eca7c5a784bc2bf76 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1720 Reviewed-by: glittershark Reviewed-by: tazjin Tested-by: BuildkiteCI --- third_party/nix/src/nix-env/nix-env.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'third_party/nix/src/nix-env/nix-env.cc') diff --git a/third_party/nix/src/nix-env/nix-env.cc b/third_party/nix/src/nix-env/nix-env.cc index 81eab2dedb..a0fad3f3d1 100644 --- a/third_party/nix/src/nix-env/nix-env.cc +++ b/third_party/nix/src/nix-env/nix-env.cc @@ -48,7 +48,7 @@ struct InstallSourceInfo { Bindings* autoArgs; }; -struct Globals : public gc { +struct Globals { InstallSourceInfo instSource; Path profile; std::shared_ptr state; -- cgit 1.4.1