From 88f337588c9f1a41ac67b3afb8d43f124b4d153b Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Tue, 19 May 2020 22:02:23 +0100 Subject: refactor(3p/nix): Make all single-argument constructors explicit Implicit constructors can be confusing, especially in a codebase that is already as unintentionally obfuscated as this one. https://google.github.io/styleguide/cppguide.html#Explicit_Constructors --- third_party/nix/src/nix-daemon/nix-daemon.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'third_party/nix/src/nix-daemon/nix-daemon.cc') diff --git a/third_party/nix/src/nix-daemon/nix-daemon.cc b/third_party/nix/src/nix-daemon/nix-daemon.cc index 4f71a0c36fe2..0e5d7ac8baa6 100644 --- a/third_party/nix/src/nix-daemon/nix-daemon.cc +++ b/third_party/nix/src/nix-daemon/nix-daemon.cc @@ -74,7 +74,7 @@ struct TunnelLogger { unsigned int clientVersion; - TunnelLogger(unsigned int clientVersion) : clientVersion(clientVersion) {} + explicit TunnelLogger(unsigned int clientVersion) : clientVersion(clientVersion) {} void enqueueMsg(const std::string& s) { auto state(state_.lock()); @@ -150,7 +150,7 @@ struct TunnelLogger { struct TunnelSink : Sink { Sink& to; - TunnelSink(Sink& to) : to(to) {} + explicit TunnelSink(Sink& to) : to(to) {} virtual void operator()(const unsigned char* data, size_t len) { to << STDERR_WRITE; writeString(data, len, to); @@ -159,7 +159,7 @@ struct TunnelSink : Sink { struct TunnelSource : BufferedSource { Source& from; - TunnelSource(Source& from) : from(from) {} + explicit TunnelSource(Source& from) : from(from) {} protected: size_t readUnbuffered(unsigned char* data, size_t len) override { -- cgit 1.4.1