From 72fc2fd27e8ca9ddd6dad7f1c8f508e115aa2b60 Mon Sep 17 00:00:00 2001 From: Kane York Date: Sat, 1 Aug 2020 15:32:00 -0700 Subject: fix(3p/nix): revert "apply all clang-tidy fixes" This reverts commit ef54f5da9fa30b5c302f2a49595ee5d041f9706a. Resolved conflicts: third_party/nix/src/libexpr/eval.cc third_party/nix/src/libstore/builtins/fetchurl.cc third_party/nix/src/libstore/references.cc third_party/nix/src/libutil/hash.cc third_party/nix/src/nix-daemon/nix-daemon.cc Change-Id: Ib9cf6e96a79a23bde3983579ced3f92e530cb011 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1547 Reviewed-by: glittershark Tested-by: BuildkiteCI --- third_party/nix/src/nix-channel/nix-channel.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'third_party/nix/src/nix-channel') diff --git a/third_party/nix/src/nix-channel/nix-channel.cc b/third_party/nix/src/nix-channel/nix-channel.cc index 7d60752e3f6e..837fb861d309 100644 --- a/third_party/nix/src/nix-channel/nix-channel.cc +++ b/third_party/nix/src/nix-channel/nix-channel.cc @@ -112,7 +112,7 @@ static void update(const StringSet& channelNames) { std::smatch match; auto urlBase = baseNameOf(url); if (std::regex_search(urlBase, match, std::regex("(-\\d.*)$"))) { - cname = cname + std::string(match[1]); + cname = cname + (std::string)match[1]; } std::string extraAttrs; @@ -163,7 +163,7 @@ static void update(const StringSet& channelNames) { runProgram(settings.nixBinDir + "/nix-env", false, envArgs); // Make the channels appear in nix-env. - struct stat st {}; + struct stat st; if (lstat(nixDefExpr.c_str(), &st) == 0) { if (S_ISLNK(st.st_mode)) { // old-skool ~/.nix-defexpr @@ -193,7 +193,7 @@ static int _main(int argc, char** argv) { enum { cNone, cAdd, cRemove, cList, cUpdate, cRollback } cmd = cNone; std::vector args; parseCmdLine(argc, argv, - [&](Strings::iterator& arg, const Strings::iterator& _end) { + [&](Strings::iterator& arg, const Strings::iterator& end) { if (*arg == "--help") { showManPage("nix-channel"); } else if (*arg == "--version") { -- cgit 1.4.1