From 6f38ac6657cabcee067a6299551d280680be16ff Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Fri, 27 Nov 2020 19:24:26 -0500 Subject: fix(tvix): Add missing break;s to BuildResult::FromProto Add missing break statements to the big switch block in BuildResult::FromProto, and cover the whole thing with a rapidcheck round-trip test. Change-Id: I7a07ca398cc5f02ca4fd8e6256fd563c6f3aea9d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2178 Tested-by: BuildkiteCI Reviewed-by: kanepyork --- third_party/nix/src/libstore/store-api.cc | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'third_party/nix/src/libstore/store-api.cc') diff --git a/third_party/nix/src/libstore/store-api.cc b/third_party/nix/src/libstore/store-api.cc index d7ca54fa9a77..d8dbea18e953 100644 --- a/third_party/nix/src/libstore/store-api.cc +++ b/third_party/nix/src/libstore/store-api.cc @@ -97,30 +97,43 @@ std::optional BuildResult::FromProto( switch (resp.status()) { case proto::BuildStatus::Built: result.status = BuildResult::Status::Built; + break; case proto::BuildStatus::Substituted: result.status = BuildResult::Status::Substituted; + break; case proto::BuildStatus::AlreadyValid: result.status = BuildResult::Status::AlreadyValid; + break; case proto::BuildStatus::PermanentFailure: result.status = BuildResult::Status::PermanentFailure; + break; case proto::BuildStatus::InputRejected: result.status = BuildResult::Status::InputRejected; + break; case proto::BuildStatus::OutputRejected: result.status = BuildResult::Status::OutputRejected; + break; case proto::BuildStatus::TransientFailure: result.status = BuildResult::Status::TransientFailure; + break; case proto::BuildStatus::CachedFailure: result.status = BuildResult::Status::CachedFailure; + break; case proto::BuildStatus::TimedOut: result.status = BuildResult::Status::TimedOut; + break; case proto::BuildStatus::MiscFailure: result.status = BuildResult::Status::MiscFailure; + break; case proto::BuildStatus::DependencyFailed: result.status = BuildResult::Status::DependencyFailed; + break; case proto::BuildStatus::LogLimitExceeded: result.status = BuildResult::Status::LogLimitExceeded; + break; case proto::BuildStatus::NotDeterministic: result.status = BuildResult::Status::NotDeterministic; + break; default: return {}; } -- cgit 1.4.1