From 88f337588c9f1a41ac67b3afb8d43f124b4d153b Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Tue, 19 May 2020 22:02:23 +0100 Subject: refactor(3p/nix): Make all single-argument constructors explicit Implicit constructors can be confusing, especially in a codebase that is already as unintentionally obfuscated as this one. https://google.github.io/styleguide/cppguide.html#Explicit_Constructors --- third_party/nix/src/libstore/remote-store.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'third_party/nix/src/libstore/remote-store.cc') diff --git a/third_party/nix/src/libstore/remote-store.cc b/third_party/nix/src/libstore/remote-store.cc index b0025df98f5b..e1fcb749a3fe 100644 --- a/third_party/nix/src/libstore/remote-store.cc +++ b/third_party/nix/src/libstore/remote-store.cc @@ -215,7 +215,7 @@ struct ConnectionHandle { Pool::Handle handle; bool daemonException = false; - ConnectionHandle(Pool::Handle&& handle) + explicit ConnectionHandle(Pool::Handle&& handle) : handle(std::move(handle)) {} ConnectionHandle(ConnectionHandle&& h) : handle(std::move(h.handle)) {} -- cgit 1.4.1