From 7a8880a0df579eeed7be2121dcd666cdb7e50f07 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Sun, 19 Jul 2020 18:03:39 +0100 Subject: refactor(3p/nix): Remove remaining prefork-compat type Removes the verbosity enum, which is no longer actively used anywhere other than a daemon protocol implementation bit that doesn't actually work. Since the verbosity was marked deprecated, this removes one of the last remaining warnings. Change-Id: Iaee9d1d6c14b30daac83bb44bcacff32a0e07fb0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1289 Tested-by: BuildkiteCI Reviewed-by: glittershark --- third_party/nix/src/libstore/remote-store.cc | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'third_party/nix/src/libstore/remote-store.cc') diff --git a/third_party/nix/src/libstore/remote-store.cc b/third_party/nix/src/libstore/remote-store.cc index 7570255330..7c4f3a138f 100644 --- a/third_party/nix/src/libstore/remote-store.cc +++ b/third_party/nix/src/libstore/remote-store.cc @@ -19,7 +19,6 @@ #include "libutil/archive.hh" #include "libutil/finally.hh" #include "libutil/pool.hh" -#include "libutil/prefork-compat.hh" #include "libutil/serialise.hh" #include "libutil/util.hh" @@ -167,14 +166,11 @@ void RemoteStore::initConnection(Connection& conn) { void RemoteStore::setOptions(Connection& conn) { conn.to << wopSetOptions << static_cast(settings.keepFailed) << static_cast(settings.keepGoing) - // TODO(tazjin): Remove the verbosity stuff here. - << static_cast(settings.tryFallback) << compat::kInfo - << settings.maxBuildJobs << settings.maxSilentTime - << 1u - // TODO(tazjin): what behaviour does this toggle remotely? - << (settings.verboseBuild ? compat::kError : compat::kVomit) - << 0 // obsolete log type - << 0 /* obsolete print build trace */ + << static_cast(settings.tryFallback) + << /* previously: verbosity = */ 0 << settings.maxBuildJobs + << settings.maxSilentTime << 1u + << /* previously: remote verbosity = */ 0 << 0 // obsolete log type + << 0 /* obsolete print build trace */ << settings.buildCores << static_cast(settings.useSubstitutes); -- cgit 1.4.1