From 43677021e3c285c2ced2075b918da947e13fcb00 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Wed, 20 May 2020 22:58:43 +0100 Subject: refactor(3p/nix): Apply clang-tidy's performance-* fixes This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html --- third_party/nix/src/libstore/nar-accessor.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'third_party/nix/src/libstore/nar-accessor.cc') diff --git a/third_party/nix/src/libstore/nar-accessor.cc b/third_party/nix/src/libstore/nar-accessor.cc index 3a8d6b884104..7f6e0377aed4 100644 --- a/third_party/nix/src/libstore/nar-accessor.cc +++ b/third_party/nix/src/libstore/nar-accessor.cc @@ -94,7 +94,7 @@ struct NarAccessor : public FSAccessor { } }; - explicit NarAccessor(ref nar) : nar(nar) { + explicit NarAccessor(const ref& nar) : nar(nar) { NarIndexer indexer(*this, *nar); parseDump(indexer, indexer); } @@ -111,7 +111,7 @@ struct NarAccessor : public FSAccessor { if (type == "directory") { member.type = FSAccessor::Type::tDirectory; for (auto i = v["entries"].begin(); i != v["entries"].end(); ++i) { - std::string name = i.key(); + const std::string& name = i.key(); recurse(member.children[name], i.value()); } } else if (type == "regular") { @@ -225,8 +225,8 @@ ref makeLazyNarAccessor(const std::string& listing, return make_ref(listing, getNarBytes); } -void listNar(JSONPlaceholder& res, ref accessor, const Path& path, - bool recurse) { +void listNar(JSONPlaceholder& res, const ref& accessor, + const Path& path, bool recurse) { auto st = accessor->stat(path); auto obj = res.object(); -- cgit 1.4.1