From d470ec0d2946d77b0e4c4b9a0a1e383c0a817167 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Thu, 16 Jul 2020 22:00:26 +0100 Subject: refactor(3p/nix/libexpr): Use Abseil collection types for parser state Replaces the previous uses of the (ordered!) std::map and std::set with absl::flat_hash_{map|set}. After some careful reading it seems that there is actually no ordering dependency on these types, and the (drop-in) replacements perform slightly better. Overall this is not fixing a bottleneck, just a driveby thing. Change-Id: Ided695dc75676bd58515aa9382df0be0a09c565e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1220 Reviewed-by: glittershark Reviewed-by: isomer Tested-by: BuildkiteCI --- third_party/nix/src/libexpr/symbol-table.hh | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'third_party/nix/src/libexpr/symbol-table.hh') diff --git a/third_party/nix/src/libexpr/symbol-table.hh b/third_party/nix/src/libexpr/symbol-table.hh index dcb44d32f623..3542f0eadad1 100644 --- a/third_party/nix/src/libexpr/symbol-table.hh +++ b/third_party/nix/src/libexpr/symbol-table.hh @@ -26,6 +26,11 @@ class Symbol { bool empty() const { return s->empty(); } friend std::ostream& operator<<(std::ostream& str, const Symbol& sym); + + template + friend H AbslHashValue(H h, const Symbol& c) { + return H::combine(std::move(h), c.s); + } }; // SymbolTable is a hash-set based symbol-interning mechanism. -- cgit 1.4.1