From a2ecd53f5822ae07fabfc7d2fac7fa929eb7f795 Mon Sep 17 00:00:00 2001 From: sterni Date: Fri, 4 Feb 2022 12:15:57 +0100 Subject: chore: clean up some obsolete TODOs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * //3p/nix: probably not worth investing time into this anymore * //users/sterni/emacs: The emoji problem disappeared by itself with a newer emacs version, however a different one remains… * //web/panettone: If we ever want to change the behavior, we should just decide the behavior statically instead of using conditions and restarts, as we only call it in one place, so making different decisions depending on call sites is not really a use case we have. Change-Id: Iff9d439ce356db41ce34d690fb7b6a01822022fa Reviewed-on: https://cl.tvl.fyi/c/depot/+/5223 Tested-by: BuildkiteCI Reviewed-by: tazjin Autosubmit: sterni --- third_party/nix/src/libexpr/primops.cc | 1 - 1 file changed, 1 deletion(-) (limited to 'third_party/nix/src/libexpr/primops.cc') diff --git a/third_party/nix/src/libexpr/primops.cc b/third_party/nix/src/libexpr/primops.cc index 710d214ce7..f196c5ed72 100644 --- a/third_party/nix/src/libexpr/primops.cc +++ b/third_party/nix/src/libexpr/primops.cc @@ -1370,7 +1370,6 @@ static void prim_functionArgs(EvalState& state, const Pos& pos, Value** args, Value& v) { state.forceValue(*args[0]); if (args[0]->type == tPrimOpApp || args[0]->type == tPrimOp) { - // TODO(sterni): return set of formal arguments for fetch* primops state.mkAttrs(v, 0); return; } -- cgit 1.4.1