From 43677021e3c285c2ced2075b918da947e13fcb00 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Wed, 20 May 2020 22:58:43 +0100 Subject: refactor(3p/nix): Apply clang-tidy's performance-* fixes This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html --- third_party/nix/src/libexpr/primops.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'third_party/nix/src/libexpr/primops.cc') diff --git a/third_party/nix/src/libexpr/primops.cc b/third_party/nix/src/libexpr/primops.cc index 7b73bec03525..307459396eae 100644 --- a/third_party/nix/src/libexpr/primops.cc +++ b/third_party/nix/src/libexpr/primops.cc @@ -34,7 +34,7 @@ namespace nix { name>. */ std::pair decodeContext(const string& s) { if (s.at(0) == '!') { - size_t index = s.find("!", 1); + size_t index = s.find('!', 1); return std::pair(string(s, index + 1), string(s, 1, index - 1)); } @@ -2172,7 +2172,7 @@ static void prim_splitVersion(EvalState& state, const Pos& pos, Value** args, unsigned int n = 0; for (auto& component : components) { auto listElem = v.listElems()[n++] = state.allocValue(); - mkString(*listElem, std::move(component)); + mkString(*listElem, component); } } @@ -2246,7 +2246,8 @@ static void prim_fetchTarball(EvalState& state, const Pos& pos, Value** args, RegisterPrimOp::PrimOps* RegisterPrimOp::primOps; -RegisterPrimOp::RegisterPrimOp(std::string name, size_t arity, PrimOpFun fun) { +RegisterPrimOp::RegisterPrimOp(const std::string& name, size_t arity, + PrimOpFun fun) { if (primOps == nullptr) { primOps = new PrimOps; } -- cgit 1.4.1