From b490742a511dd03afc43f5143d6d61edaeeb8091 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Tue, 19 May 2020 17:38:04 +0100 Subject: style(3p/nix): Enforce braces around loops and conditionals This change was generated with: fd -e cc -e hh | xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy. --- third_party/nix/src/libexpr/eval-inline.hh | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) (limited to 'third_party/nix/src/libexpr/eval-inline.hh') diff --git a/third_party/nix/src/libexpr/eval-inline.hh b/third_party/nix/src/libexpr/eval-inline.hh index 37105e7e398d..d92614ca7ca6 100644 --- a/third_party/nix/src/libexpr/eval-inline.hh +++ b/third_party/nix/src/libexpr/eval-inline.hh @@ -38,33 +38,39 @@ void EvalState::forceValue(Value& v, const Pos& pos) { v.thunk.expr = expr; throw; } - } else if (v.type == tApp) + } else if (v.type == tApp) { callFunction(*v.app.left, *v.app.right, v, noPos); - else if (v.type == tBlackhole) + } else if (v.type == tBlackhole) { throwEvalError("infinite recursion encountered, at %1%", pos); + } } inline void EvalState::forceAttrs(Value& v) { forceValue(v); - if (v.type != tAttrs) + if (v.type != tAttrs) { throwTypeError("value is %1% while a set was expected", v); + } } inline void EvalState::forceAttrs(Value& v, const Pos& pos) { forceValue(v); - if (v.type != tAttrs) + if (v.type != tAttrs) { throwTypeError("value is %1% while a set was expected, at %2%", v, pos); + } } inline void EvalState::forceList(Value& v) { forceValue(v); - if (!v.isList()) throwTypeError("value is %1% while a list was expected", v); + if (!v.isList()) { + throwTypeError("value is %1% while a list was expected", v); + } } inline void EvalState::forceList(Value& v, const Pos& pos) { forceValue(v); - if (!v.isList()) + if (!v.isList()) { throwTypeError("value is %1% while a list was expected, at %2%", v, pos); + } } /* Note: Various places expect the allocated memory to be zeroed. */ -- cgit 1.4.1