From 3593c8285dec644f07156496fd8cd84ef70ec665 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 30 May 2016 13:55:09 +0200 Subject: Re-implement binary cache signature checking This is now done in LocalStore::addToStore(), rather than in the binary cache substituter (which no longer exists). --- src/libstore/local-store.cc | 5 +++++ src/libstore/local-store.hh | 4 ++++ 2 files changed, 9 insertions(+) (limited to 'src') diff --git a/src/libstore/local-store.cc b/src/libstore/local-store.cc index 8608b39ec5bd..b44384957ca6 100644 --- a/src/libstore/local-store.cc +++ b/src/libstore/local-store.cc @@ -58,6 +58,8 @@ LocalStore::LocalStore() : linksDir(settings.nixStore + "/.links") , reservedPath(settings.nixDBPath + "/reserved") , schemaPath(settings.nixDBPath + "/schema") + , requireSigs(settings.get("signed-binary-caches", std::string("")) != "") // FIXME: rename option + , publicKeys(getDefaultPublicKeys()) { auto state(_state.lock()); @@ -909,6 +911,9 @@ void LocalStore::addToStore(const ValidPathInfo & info, const std::string & nar, throw Error(format("hash mismatch importing path ‘%s’; expected hash ‘%s’, got ‘%s’") % info.path % info.narHash.to_string() % h.to_string()); + if (requireSigs && !info.checkSignatures(publicKeys)) + throw Error(format("cannot import path ‘%s’ because it lacks a valid signature") % info.path); + addTempRoot(info.path); if (repair || !isValidPath(info.path)) { diff --git a/src/libstore/local-store.hh b/src/libstore/local-store.hh index e714f8e0feb1..8de58cea8e43 100644 --- a/src/libstore/local-store.hh +++ b/src/libstore/local-store.hh @@ -77,6 +77,10 @@ private: const Path reservedPath; const Path schemaPath; + bool requireSigs; + + PublicKeys publicKeys; + public: /* Initialise the local store, upgrading the schema if -- cgit 1.4.1