From 75068e7d753cf6cbe45a4bf294000dca9bd41d8b Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 4 Sep 2006 21:06:23 +0000 Subject: * Use a proper namespace. * Optimise header file usage a bit. * Compile the parser as C++. --- src/nix-env/main.cc | 19 +++++++++++++------ src/nix-env/names.cc | 7 +++++++ src/nix-env/names.hh | 9 ++++++--- src/nix-env/profiles.cc | 8 ++++++++ src/nix-env/profiles.hh | 8 ++++++-- 5 files changed, 40 insertions(+), 11 deletions(-) (limited to 'src/nix-env') diff --git a/src/nix-env/main.cc b/src/nix-env/main.cc index b3caaeac8277..7a6824b63acf 100644 --- a/src/nix-env/main.cc +++ b/src/nix-env/main.cc @@ -13,6 +13,9 @@ #include "attr-path.hh" #include "pathlocks.hh" #include "xml-writer.hh" +#include "store.hh" +#include "db.hh" +#include "util.hh" #include #include @@ -23,6 +26,10 @@ #include +using namespace nix; +using std::cout; + + typedef enum { srcNixExprDrvs, srcNixExprs, @@ -224,7 +231,7 @@ static DrvInfos filterBySelector(EvalState & state, for (DrvNames::iterator i = selectors.begin(); i != selectors.end(); ++i) { - typedef list > Matches; + typedef list > Matches; Matches matches; unsigned int n = 0; for (DrvInfos::const_iterator j = allElems.begin(); @@ -233,7 +240,7 @@ static DrvInfos filterBySelector(EvalState & state, DrvName drvName(j->name); if (i->matches(drvName)) { i->hits++; - matches.push_back(pair(*j, n)); + matches.push_back(std::pair(*j, n)); } } @@ -244,7 +251,7 @@ static DrvInfos filterBySelector(EvalState & state, if (newestOnly) { /* Map from package names to derivations. */ - typedef map > Newest; + typedef map > Newest; Newest newest; StringSet multiple; @@ -350,7 +357,7 @@ static void queryInstSources(EvalState & state, assertStorePath(*i); DrvInfo elem; - elem.attrs = shared_ptr(new ATermMap(0)); /* ugh... */ + elem.attrs = boost::shared_ptr(new ATermMap(0)); /* ugh... */ string name = baseNameOf(*i); string::size_type dash = name.find('-'); if (dash != string::npos) @@ -667,7 +674,7 @@ void printTable(Table & table) if (column < nrColumns - 1) cout << string(widths[column] - j->size() + 2, ' '); } - cout << endl; + cout << std::endl; } } @@ -801,7 +808,7 @@ static void opQuery(Globals & globals, /* Print the desired columns, or XML output. */ Table table; - ostringstream dummy; + std::ostringstream dummy; XMLWriter xml(true, *(xmlOutput ? &cout : &dummy)); XMLOpenElement xmlRoot(xml, "items"); diff --git a/src/nix-env/names.cc b/src/nix-env/names.cc index 93bcfda24e60..a425b8d0762c 100644 --- a/src/nix-env/names.cc +++ b/src/nix-env/names.cc @@ -1,4 +1,8 @@ #include "names.hh" +#include "util.hh" + + +namespace nix { DrvName::DrvName() @@ -115,3 +119,6 @@ DrvNames drvNamesFromArgs(const Strings & opArgs) result.push_back(DrvName(*i)); return result; } + + +} diff --git a/src/nix-env/names.hh b/src/nix-env/names.hh index aeb923546fd8..e189302d6d94 100644 --- a/src/nix-env/names.hh +++ b/src/nix-env/names.hh @@ -1,10 +1,10 @@ #ifndef __NAMES_H #define __NAMES_H -#include -#include +#include "types.hh" -#include "util.hh" + +namespace nix { struct DrvName @@ -27,4 +27,7 @@ int compareVersions(const string & v1, const string & v2); DrvNames drvNamesFromArgs(const Strings & opArgs); +} + + #endif /* !__NAMES_H */ diff --git a/src/nix-env/profiles.cc b/src/nix-env/profiles.cc index 6ec12e604c73..0db5bda5e9b6 100644 --- a/src/nix-env/profiles.cc +++ b/src/nix-env/profiles.cc @@ -1,4 +1,5 @@ #include "profiles.hh" +#include "util.hh" #include #include @@ -7,6 +8,9 @@ #include +namespace nix { + + static bool cmpGensByNumber(const Generation & a, const Generation & b) { return a.number < b.number; @@ -126,3 +130,7 @@ void switchLink(Path link, Path target) if (rename(tmp.c_str(), link.c_str()) != 0) throw SysError(format("renaming `%1%' to `%2%'") % tmp % link); } + + +} + diff --git a/src/nix-env/profiles.hh b/src/nix-env/profiles.hh index dc27d1c83de8..2bd05045eafb 100644 --- a/src/nix-env/profiles.hh +++ b/src/nix-env/profiles.hh @@ -1,9 +1,10 @@ #ifndef __PROFILES_H #define __PROFILES_H -#include +#include "types.hh" -#include "util.hh" + +namespace nix { struct Generation @@ -35,4 +36,7 @@ void deleteGeneration(const Path & profile, unsigned int gen); void switchLink(Path link, Path target); +} + + #endif /* !__PROFILES_H */ -- cgit 1.4.1