From 2b9d0a99cbf7649c20492bc539e2823a2d2e57c5 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 16 Jan 2017 22:24:29 +0100 Subject: AutoDeleteArray -> std::unique_ptr Also, switch to C++14 for std::make_unique. --- src/libutil/serialise.cc | 8 ++++---- src/libutil/util.cc | 7 +++---- src/libutil/util.hh | 12 ------------ 3 files changed, 7 insertions(+), 20 deletions(-) (limited to 'src/libutil') diff --git a/src/libutil/serialise.cc b/src/libutil/serialise.cc index 24c6d107359e..a68f7a0fa8ee 100644 --- a/src/libutil/serialise.cc +++ b/src/libutil/serialise.cc @@ -3,6 +3,7 @@ #include #include +#include namespace nix { @@ -236,11 +237,10 @@ size_t readString(unsigned char * buf, size_t max, Source & source) string readString(Source & source) { size_t len = readInt(source); - unsigned char * buf = new unsigned char[len]; - AutoDeleteArray d(buf); - source(buf, len); + auto buf = std::make_unique(len); + source(buf.get(), len); readPadding(len, source); - return string((char *) buf, len); + return string((char *) buf.get(), len); } Source & operator >> (Source & in, string & s) diff --git a/src/libutil/util.cc b/src/libutil/util.cc index ce16cc30a5c7..0e1849df09ea 100644 --- a/src/libutil/util.cc +++ b/src/libutil/util.cc @@ -272,11 +272,10 @@ string readFile(int fd) if (fstat(fd, &st) == -1) throw SysError("statting file"); - unsigned char * buf = new unsigned char[st.st_size]; - AutoDeleteArray d(buf); - readFull(fd, buf, st.st_size); + auto buf = std::make_unique(st.st_size); + readFull(fd, buf.get(), st.st_size); - return string((char *) buf, st.st_size); + return string((char *) buf.get(), st.st_size); } diff --git a/src/libutil/util.hh b/src/libutil/util.hh index 50b96f7ed92c..d420997815f5 100644 --- a/src/libutil/util.hh +++ b/src/libutil/util.hh @@ -139,18 +139,6 @@ string drainFD(int fd); /* Automatic cleanup of resources. */ -template -struct AutoDeleteArray -{ - T * p; - AutoDeleteArray(T * p) : p(p) { } - ~AutoDeleteArray() - { - delete [] p; - } -}; - - class AutoDelete { Path path; -- cgit 1.4.1