From 1511aa9f488ba0762c2da0bf8ab61b5fde47305d Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 17 Jul 2015 17:57:40 +0200 Subject: Allow remote builds without sending the derivation closure Previously, to build a derivation remotely, we had to copy the entire closure of the .drv file to the remote machine, even though we only need the top-level derivation. This is very wasteful: the closure can contain thousands of store paths, and in some Hydra use cases, include source paths that are very large (e.g. Git/Mercurial checkouts). So now there is a new operation, StoreAPI::buildDerivation(), that performs a build from an in-memory representation of a derivation (BasicDerivation) rather than from a on-disk .drv file. The only files that need to be in the Nix store are the sources of the derivation (drv.inputSrcs), and the needed output paths of the dependencies (as described by drv.inputDrvs). "nix-store --serve" exposes this interface. Note that this is a privileged operation, because you can construct a derivation that builds any store path whatsoever. Fixing this will require changing the hashing scheme (i.e., the output paths should be computed from the other fields in BasicDerivation, allowing them to be verified without access to other derivations). However, this would be quite nice because it would allow .drv-free building (e.g. "nix-env -i" wouldn't have to write any .drv files to disk). Fixes #173. --- src/libutil/serialise.cc | 32 +++++++++++++++++++++++++++++++- src/libutil/serialise.hh | 8 ++++++++ 2 files changed, 39 insertions(+), 1 deletion(-) (limited to 'src/libutil') diff --git a/src/libutil/serialise.cc b/src/libutil/serialise.cc index 92417507508a..aa16a20e6d35 100644 --- a/src/libutil/serialise.cc +++ b/src/libutil/serialise.cc @@ -155,6 +155,12 @@ void writeInt(unsigned int n, Sink & sink) sink(buf, sizeof(buf)); } +Sink & operator << (Sink & out, unsigned int n) +{ + writeInt(n, out); + return out; +} + void writeLongLong(unsigned long long n, Sink & sink) { @@ -184,6 +190,12 @@ void writeString(const string & s, Sink & sink) writeString((const unsigned char *) s.data(), s.size(), sink); } +Sink & operator << (Sink & out, const string & s) +{ + writeString(s, out); + return out; +} + template void writeStrings(const T & ss, Sink & sink) { @@ -195,6 +207,18 @@ template void writeStrings(const T & ss, Sink & sink) template void writeStrings(const Paths & ss, Sink & sink); template void writeStrings(const PathSet & ss, Sink & sink); +Sink & operator << (Sink & out, const Strings & s) +{ + writeStrings(s, out); + return out; +} + +Sink & operator << (Sink & out, const StringSet & s) +{ + writeStrings(s, out); + return out; +} + void readPadding(size_t len, Source & source) { @@ -258,7 +282,13 @@ string readString(Source & source) return string((char *) buf, len); } - +Source & operator >> (Source & in, string & s) +{ + s = readString(in); + return in; +} + + template T readStrings(Source & source) { unsigned int count = readInt(source); diff --git a/src/libutil/serialise.hh b/src/libutil/serialise.hh index 6a6f028aa652..3a20ad032254 100644 --- a/src/libutil/serialise.hh +++ b/src/libutil/serialise.hh @@ -118,6 +118,12 @@ void writeString(const unsigned char * buf, size_t len, Sink & sink); void writeString(const string & s, Sink & sink); template void writeStrings(const T & ss, Sink & sink); +Sink & operator << (Sink & out, unsigned int n); +Sink & operator << (Sink & out, const string & s); +Sink & operator << (Sink & out, const Strings & s); +Sink & operator << (Sink & out, const StringSet & s); + + void readPadding(size_t len, Source & source); unsigned int readInt(Source & source); unsigned long long readLongLong(Source & source); @@ -125,6 +131,8 @@ size_t readString(unsigned char * buf, size_t max, Source & source); string readString(Source & source); template T readStrings(Source & source); +Source & operator >> (Source & in, string & s); + MakeError(SerialisationError, Error) -- cgit 1.4.1