From 85799bf89ed2649d7f3e2298de0478c50a71776d Mon Sep 17 00:00:00 2001 From: Lluís Batlle i Rossell Date: Thu, 22 Mar 2012 20:05:54 +0100 Subject: Fixing the default of sync-before-registering Setting 'false' as default, as suggested by Eelco. I also added a comment about the setting in the code. --- src/libstore/local-store.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/libstore/local-store.cc') diff --git a/src/libstore/local-store.cc b/src/libstore/local-store.cc index 950e6e7608f1..ca541e1cce2e 100644 --- a/src/libstore/local-store.cc +++ b/src/libstore/local-store.cc @@ -968,8 +968,12 @@ void LocalStore::registerValidPath(const ValidPathInfo & info) void LocalStore::registerValidPaths(const ValidPathInfos & infos) { - if (queryBoolSetting("sync-before-registering", true)) + /* sqlite will fsync by default, but the new valid paths may not be fsync-ed. + * So some may want to fsync them before registering the validity, at the + * expense of some speed of the path registering operation. */ + if (queryBoolSetting("sync-before-registering", false)) sync(); + while (1) { try { SQLiteTxn txn(db); -- cgit 1.4.1