From 5664b6d7ba28453ccdd6d1c07a707f98608500ff Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 11 Aug 2008 13:36:40 +0000 Subject: * Removed the "valid values" feature. Nobody uses it anyway. --- src/libexpr/eval.cc | 49 +++++-------------------------------------------- 1 file changed, 5 insertions(+), 44 deletions(-) (limited to 'src/libexpr/eval.cc') diff --git a/src/libexpr/eval.cc b/src/libexpr/eval.cc index 6d8137d9b812..15cccc6b7f56 100644 --- a/src/libexpr/eval.cc +++ b/src/libexpr/eval.cc @@ -92,9 +92,8 @@ static Expr substArgs(EvalState & state, ATermList recAttrs = ATempty; for (ATermIterator i(formals); i; ++i) { Expr name, def; - ValidValues valids2; DefaultValue def2; - if (!matchFormal(*i, name, valids2, def2)) abort(); /* can't happen */ + if (!matchFormal(*i, name, def2)) abort(); /* can't happen */ Expr value = subs[name]; @@ -106,21 +105,6 @@ static Expr substArgs(EvalState & state, defsUsed.push_back(name); recAttrs = ATinsert(recAttrs, makeBind(name, def, makeNoPos())); } - - ATermList valids; - if (matchValidValues(valids2, valids)) { - value = evalExpr(state, value); - bool found = false; - for (ATermIterator j(valids); j; ++j) { - Expr v = evalExpr(state, *j); - if (value == v) { - found = true; - break; - } - } - if (!found) throw TypeError(format("the argument named `%1%' has an illegal value") - % aterm2String(name)); - } } /* Make a recursive attribute set out of the (argument-name, @@ -139,8 +123,8 @@ static Expr substArgs(EvalState & state, /* One or more actual arguments were not declared as formal arguments. Find out which. */ for (ATermIterator i(formals); i; ++i) { - Expr name; ATerm d1, d2; - if (!matchFormal(*i, name, d1, d2)) abort(); + Expr name; ATerm d1; + if (!matchFormal(*i, name, d1)) abort(); subs.remove(name); } throw TypeError(format("the function does not expect an argument named `%1%'") @@ -393,8 +377,8 @@ Expr autoCallFunction(Expr e, const ATermMap & args) ATermMap actualArgs(ATgetLength(formals)); for (ATermIterator i(formals); i; ++i) { - Expr name, def, value; ATerm values, def2; - if (!matchFormal(*i, name, values, def2)) abort(); + Expr name, def, value; ATerm def2; + if (!matchFormal(*i, name, def2)) abort(); if ((value = args.get(name))) actualArgs.set(name, makeAttrRHS(value, makeNoPos())); else if (!matchDefaultValue(def2, def)) @@ -800,29 +784,6 @@ static Expr strictEvalExpr_(EvalState & state, Expr e, ATermMap & nfs) return makeList(ATreverse(es2)); } - ATermList formals; - ATerm body, pos; - if (matchFunction(e, formals, body, pos)) { - ATermList formals2 = ATempty; - - for (ATermIterator i(formals); i; ++i) { - Expr name; ValidValues valids; ATerm dummy; - if (!matchFormal(*i, name, valids, dummy)) abort(); - - ATermList valids2; - if (matchValidValues(valids, valids2)) { - ATermList valids3 = ATempty; - for (ATermIterator j(valids2); j; ++j) - valids3 = ATinsert(valids3, strictEvalExpr(state, *j, nfs)); - valids = makeValidValues(ATreverse(valids3)); - } - - formals2 = ATinsert(formals2, makeFormal(name, valids, dummy)); - } - - return makeFunction(ATreverse(formals2), body, pos); - } - return e; } -- cgit 1.4.1