From 24c68069948681366ff2351dd7400af6e69006d9 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 11 Jun 2018 16:06:01 +0200 Subject: Cache parse trees This prevents EvalState::resetFileCache() from parsing everything all over again. --- src/libexpr/eval.cc | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'src/libexpr/eval.cc') diff --git a/src/libexpr/eval.cc b/src/libexpr/eval.cc index 01658aa25f28..facfddbb5300 100644 --- a/src/libexpr/eval.cc +++ b/src/libexpr/eval.cc @@ -332,7 +332,6 @@ EvalState::EvalState(const Strings & _searchPath, ref store) EvalState::~EvalState() { - fileEvalCache.clear(); } @@ -711,7 +710,17 @@ void EvalState::evalFile(const Path & path_, Value & v) } printTalkative("evaluating file '%1%'", path2); - Expr * e = parseExprFromFile(checkSourcePath(path2)); + Expr * e = nullptr; + + auto j = fileParseCache.find(path2); + if (j != fileParseCache.end()) + e = j->second; + + if (!e) + e = parseExprFromFile(checkSourcePath(path2)); + + fileParseCache[path2] = e; + try { eval(e, v); } catch (Error & e) { -- cgit 1.4.1