From f8b4029b1744bea77cc3f941d59c09d11f714f47 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Sun, 19 Dec 2021 19:37:18 +0300 Subject: fix(ops/besadii): Stop path.Join from eating our URL apparently this chomps away at things inside of fragment strings Change-Id: Ie60d52d101dc4281b3a62c228af076791e1c7928 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4462 Tested-by: BuildkiteCI Reviewed-by: grfn --- ops/besadii/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ops') diff --git a/ops/besadii/main.go b/ops/besadii/main.go index 5c9baf6bf530..b382821bcce7 100644 --- a/ops/besadii/main.go +++ b/ops/besadii/main.go @@ -160,7 +160,7 @@ func loadConfig() (*config, error) { // linkToChange creates the full link to a change's patchset in Gerrit func linkToChange(cfg *config, changeId, patchset string) string { - return path.Join(cfg.GerritUrl, "c", cfg.Repository, "+", changeId, patchset) + return fmt.Sprintf("%s/c/%s/+/%s/%s", cfg.GerritUrl, "c", cfg.Repository, "+", changeId, patchset) } // updateGerrit posts a comment on a Gerrit CL to indicate the current build status. -- cgit 1.4.1