From adf092a26be9da18448e96e1e6198d543d187c63 Mon Sep 17 00:00:00 2001 From: Luke Granger-Brown Date: Mon, 19 Sep 2022 05:36:40 +0000 Subject: feat(monorepo-gerrit): swap owners plugin for code-owners Change-Id: I9e05384b58dac258bc2da41c22e321b20451ef00 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6686 Reviewed-by: tazjin Autosubmit: lukegb Tested-by: BuildkiteCI --- ops/modules/monorepo-gerrit.nix | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'ops') diff --git a/ops/modules/monorepo-gerrit.nix b/ops/modules/monorepo-gerrit.nix index 67be5410dc..d41e02764c 100644 --- a/ops/modules/monorepo-gerrit.nix +++ b/ops/modules/monorepo-gerrit.nix @@ -28,7 +28,7 @@ in ]; plugins = with depot.third_party.gerrit_plugins; [ - owners + code-owners oauth depot.ops.gerrit-tvl ]; @@ -107,6 +107,15 @@ in # client-secret is set in /var/lib/gerrit/etc/secure.config. }; + plugin.code-owners = { + # A Code-Review +2 vote is required from a code owner. + requiredApproval = "Code-Review+2"; + # The OWNERS check can be overriden using an Owners-Override vote. + overrideApproval = "Owners-Override+1"; + # People implicitly approve their own changes automatically. + enableImplicitApprovals = "TRUE"; + }; + # Allow users to add additional email addresses to their accounts. oauth.allowRegisterNewEmail = true; -- cgit 1.4.1