From 65be8f20e0508cb8f81a7b42a240ebb8a03d8a93 Mon Sep 17 00:00:00 2001
From: Vincent Ambo <mail@tazj.in>
Date: Tue, 13 Apr 2021 12:21:42 +0200
Subject: chore(nixpkgs): Bump channels to 2021-05-25

* users/grfn/system/home/yeren: remove obsolete awscli2 overrides

* ops: make new isSystemUser || isNormalUser assertion happy

* users/grfn/system/system/mugwump: make buildkite agents system users

* users/tazjin/nixos/camden: set isSystemUser = true for git

* users/tazjin/emacs: Remove missing & broken packages

* third_party/openldap: remove, as the argon2 module is now enabled upstream

* third_party/gerrit_plugins: Pinned new unstable hashes

* third_party/nix, third_party/grpc: Disabled CI as these are broken

* third_party/overlays/emacs: Bumped version to stay in sync with channel

* third_party/buzz: Update LIBCLANG_PATH to reference libclang.lib,
  since libclang's default output no longer contains libclang.so

* users/grfn/system/home: Install julia-stable instead of julia (which
  aliases to julia-lts), as the latter depends on an insecure version of
  libgit

Change-Id: Iff33b0ecb0ef07a82d1de35e23c40d2f4bf0f8ed
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3001
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
Reviewed-by: grfn <grfn@gws.fyi>
---
 ops/machines/whitby/default.nix   |  2 +-
 ops/modules/clbot.nix             |  2 +-
 ops/modules/quassel.nix           |  2 +-
 ops/modules/tvl-buildkite.nix     |  1 +
 ops/modules/tvl-slapd/default.nix | 13 +------------
 ops/modules/tvl-sso/default.nix   |  5 ++++-
 6 files changed, 9 insertions(+), 16 deletions(-)

(limited to 'ops')

diff --git a/ops/machines/whitby/default.nix b/ops/machines/whitby/default.nix
index 3dd081f4cf8a..6d338c369fc0 100644
--- a/ops/machines/whitby/default.nix
+++ b/ops/machines/whitby/default.nix
@@ -595,7 +595,7 @@ in {
     groups.git = {};
     users.git = {
       group = "git";
-      isNormalUser = false;
+      isSystemUser = true;
       createHome = true;
       home = "/var/lib/git";
     };
diff --git a/ops/modules/clbot.nix b/ops/modules/clbot.nix
index ad33e25a4d54..71ff2fbc3288 100644
--- a/ops/modules/clbot.nix
+++ b/ops/modules/clbot.nix
@@ -66,7 +66,7 @@ in {
 
       users.clbot = {
         group = "clbot";
-        isNormalUser = false;
+        isSystemUser = true;
       };
     };
 
diff --git a/ops/modules/quassel.nix b/ops/modules/quassel.nix
index df26a3945532..9c8692629a2a 100644
--- a/ops/modules/quassel.nix
+++ b/ops/modules/quassel.nix
@@ -66,7 +66,7 @@ in {
 
     users = {
       users.quassel = {
-        isNormalUser = false;
+        isSystemUser = true;
         group = "quassel";
       };
 
diff --git a/ops/modules/tvl-buildkite.nix b/ops/modules/tvl-buildkite.nix
index 2aa3b81811f4..05a5e9b5e7f6 100644
--- a/ops/modules/tvl-buildkite.nix
+++ b/ops/modules/tvl-buildkite.nix
@@ -39,6 +39,7 @@ in {
       users = builtins.listToAttrs (map (n: rec {
         name = "buildkite-agent-whitby-${toString n}";
         value = {
+          isSystemUser = true;
           group = lib.mkForce "buildkite-agents";
           extraGroups = [ name ];
         };
diff --git a/ops/modules/tvl-slapd/default.nix b/ops/modules/tvl-slapd/default.nix
index cbfdeff31eb0..dbcf139338ea 100644
--- a/ops/modules/tvl-slapd/default.nix
+++ b/ops/modules/tvl-slapd/default.nix
@@ -27,17 +27,6 @@ let
   inherit (depot.ops) users;
 
 in {
-  # Use our patched OpenLDAP derivation which enables stronger password hashing.
-  #
-  # Unfortunately the module for OpenLDAP has no package option, so we
-  # need to override it system-wide. Be aware that this triggers a
-  # *large* number of rebuilds of packages such as GPG and Python.
-  nixpkgs.overlays = [
-    (_: _: {
-      inherit (depot.third_party) openldap;
-    })
-  ];
-
   services.openldap = {
     enable = true;
 
@@ -58,7 +47,7 @@ in {
       };
 
       "cn=schema".includes =
-        map (schema: "${depot.third_party.openldap}/etc/schema/${schema}.ldif")
+        map (schema: "${pkgs.openldap}/etc/schema/${schema}.ldif")
             [ "core" "cosine" "inetorgperson" "nis" ];
     };
 
diff --git a/ops/modules/tvl-sso/default.nix b/ops/modules/tvl-sso/default.nix
index 8e33c708b7f3..d026c1e7c9ad 100644
--- a/ops/modules/tvl-sso/default.nix
+++ b/ops/modules/tvl-sso/default.nix
@@ -18,7 +18,10 @@ in {
         Restart = "always";
       };
     };
-    users.users.apereo-cas = {};
+    users.users.apereo-cas = {
+      isSystemUser = true;
+      group = "apereo-cas";
+    };
     users.groups.apereo-cas = {};
   };
 }
-- 
cgit 1.4.1