From 005cd4037a88f491baf6b6d402f961cd2f44594c Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Fri, 14 Jan 2022 23:40:03 +0300 Subject: fix(gerrit-tvl): Handle "broken" (skipped) jobs correctly by simply skipping them Change-Id: I9cbec3b79469ae01b1873d6a42e990b98cc4110a Reviewed-on: https://cl.tvl.fyi/c/depot/+/4921 Autosubmit: tazjin Tested-by: BuildkiteCI Reviewed-by: lukegb --- ops/gerrit-tvl/static/tvl.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'ops/gerrit-tvl') diff --git a/ops/gerrit-tvl/static/tvl.js b/ops/gerrit-tvl/static/tvl.js index b1ce3eda3abb..2c4d7ee4739c 100644 --- a/ops/gerrit-tvl/static/tvl.js +++ b/ops/gerrit-tvl/static/tvl.js @@ -116,6 +116,12 @@ const tvlChecksProvider = { continue; } + // Skip jobs marked as 'broken' (this means they were skipped + // intentionally) + if (job.state === 'broken') { + continue; + } + // TODO(lukegb): add the ability to retry these const checkRun = { patchset: parseInt(build.env.GERRIT_PATCHSET, 10), @@ -150,7 +156,7 @@ const tvlChecksProvider = { } checkRun.statusDescription = statusDescription; - if (['failed', 'broken', 'timed_out'].includes(job.state)) { + if (['failed', 'timed_out'].includes(job.state)) { const result = { // TODO(lukegb): get the log as the message here (the Gerrit // implementation doesn't yet seem to support newlines in message -- cgit 1.4.1