From c4ea2053877f3560b349b6f339f78baca4b06290 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Tue, 17 Oct 2023 13:49:03 +0100 Subject: chore(nix/bufCheck): remove git status check buf lint already happens in other individual targets, and as no generation happens in here anymore either, there's no need to check for git status to record changes anymore. Change-Id: Ieb8fc4760a61dd0f0e03f0ec388062dd2303c37a Reviewed-on: https://cl.tvl.fyi/c/depot/+/9789 Tested-by: BuildkiteCI Reviewed-by: Connor Brewster --- nix/bufCheck/default.nix | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) (limited to 'nix') diff --git a/nix/bufCheck/default.nix b/nix/bufCheck/default.nix index 90c0ca3cb6..d0f07d996b 100644 --- a/nix/bufCheck/default.nix +++ b/nix/bufCheck/default.nix @@ -1,20 +1,9 @@ -# Check protobuf syntax and breaking. +# Check protobuf breaking. Lints already happen in individual targets. # { depot, pkgs, ... }: pkgs.writeShellScriptBin "ci-buf-check" '' - export PATH="$PATH:${pkgs.lib.makeBinPath [ pkgs.buf pkgs.protoc-gen-go pkgs.protoc-gen-go-grpc ]}" - (cd $(git rev-parse --show-toplevel) && buf lint .) - - # Check if any files have changed - if [[ -n "$(git status --porcelain -unormal)" ]]; then - echo "-----------------------------" - echo ".pb.go files need to be updated" - echo "-----------------------------" - git status -unormal - exit 1 - fi - + export PATH="$PATH:${pkgs.lib.makeBinPath [ pkgs.buf ]}" # Report-only (cd $(git rev-parse --show-toplevel) && (buf breaking . --against "./.git#ref=HEAD~1" || true)) '' -- cgit 1.4.1