From b9f510d98961241786290893afcebadf22ad5eef Mon Sep 17 00:00:00 2001 From: sterni Date: Mon, 20 Dec 2021 11:08:48 +0100 Subject: fix(nix/buildLisp): don't emit a target for impl used at top level These targets would be the same derivation, but named differently which is noisy and causes a few, mostly subtle issues: * Buildkite struggles with large pipelines a bit, we can save quite a few steps by removing these. * Having two jobs for the same derivation sometimes causes the annoying situation that an agent would do nothing except waiting for a lock. * Non-nix CI we add in the future may not be able to recognize that these targets are the same and do extra work unnecessarily. Change-Id: I1103e719ade1d3859d222b713969ac34a8765cba Reviewed-on: https://cl.tvl.fyi/c/depot/+/4515 Autosubmit: sterni Tested-by: BuildkiteCI Reviewed-by: tazjin --- nix/buildLisp/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'nix/buildLisp') diff --git a/nix/buildLisp/default.nix b/nix/buildLisp/default.nix index 1dae0efeb1..c44e841894 100644 --- a/nix/buildLisp/default.nix +++ b/nix/buildLisp/default.nix @@ -143,7 +143,7 @@ let let implementation = old.implementation or defaultImplementation; brokenOn = old.brokenOn or []; - targets = lib.subtractLists brokenOn + targets = lib.subtractLists (brokenOn ++ [ implementation.name ]) (builtins.attrNames impls); in { passthru = (old.passthru or {}) // { -- cgit 1.4.1