From a2ac8a66c1bf151a9d70704b23ec2bd2dd3b99a6 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 19 Nov 2022 21:14:22 +0000 Subject: feat(nix/bufCheck): ensure .pb.go is up to date Change-Id: I03e1c3aced266966f6959dbce05c1f1fb1480b5a Reviewed-on: https://cl.tvl.fyi/c/depot/+/7323 Reviewed-by: tazjin Tested-by: BuildkiteCI --- nix/bufCheck/default.nix | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) (limited to 'nix/bufCheck') diff --git a/nix/bufCheck/default.nix b/nix/bufCheck/default.nix index 25a8865d8dcf..97b4124d4569 100644 --- a/nix/bufCheck/default.nix +++ b/nix/bufCheck/default.nix @@ -3,7 +3,20 @@ { depot, pkgs, ... }: pkgs.writeShellScriptBin "ci-buf-check" '' - ${depot.third_party.nixpkgs.buf}/bin/buf lint . + export PATH="$PATH:${pkgs.lib.makeBinPath [ pkgs.buf pkgs.protoc-gen-go pkgs.protoc-gen-go-grpc ]}" + buf lint . + + # Run buf generate, and bail out if generated files are changed. + buf generate --path tvix/store/protos + # Check if any files have changed + if [[ -n "$(git status --porcelain -unormal)" ]]; then + echo "-----------------------------" + echo ".pb.go files need to be updated" + echo "-----------------------------" + git status -unormal + exit 1 + fi + # Report-only - ${depot.third_party.nixpkgs.buf}/bin/buf breaking . --against "./.git#ref=HEAD~1" || true + buf breaking . --against "./.git#ref=HEAD~1" || true '' -- cgit 1.4.1