From 02566cdcfb15043070c990ec17c0405313a13874 Mon Sep 17 00:00:00 2001 From: sterni Date: Mon, 9 Aug 2021 02:47:07 +0200 Subject: feat(nix/buildLisp): add ecl Adds ECL as a second supported implementation, specifically a statically linked ECL. This is interesting because we can create statically linked binaries, but has a few drawbacks which doesn't make it generally useful: * Loading things is very slow: The statically linked ECL only has byte compilation available, so when we do load things or use the REPL it is significantly worse than with e. g. SBCL. * We can't load shared objects via the FFI since ECL's dffi is not available when linked statically. This means that as it stands, we can't build a statically linked //web/panettone for example. Since ECL is quite slow anyways, I think these drawbacks are worth it since the biggest reason for using ECL would be to get a statically linked binary. If we change our minds, it shouldn't be too hard to provide ecl-static and ecl-dynamic as separate implementations. ECL is LGPL and some libraries it uses as part of its runtime are as well. I've outlined in the ecl-static overlay why this should be of no concern in the context of depot even though we are statically linking. Currently everything is building except projects that are using cffi to load shared libaries which have gotten an appropriate `badImplementations` entry. To get the rest building the following changes were made: * Anywhere a dependency on UIOP is expressed as `bundled "uiop"` we now use `bundled "asdf"` for all implementations except SBCL. From my testing, SBCL seems to be the only implementation to support using `(require 'uiop)` to only load the UIOP package. Where both a dependency on ASDF and UIOP exists, we just delete the UIOP one. `(require 'asdf)` always causes UIOP to be available. * Where appropriate only conditionally compile SBCL-specific code and if any build the corresponding files for ECL. * //lisp/klatre: Use the standard condition parse-error for all implementations except SBCL in try-parse-integer. * //3p/lisp/ironclad: disable SBCL assembly optimization hack for all other platforms as it may interfere with compilation. * //3p/lisp/trivial-mimes: prevent call to asdf function by substituting it out of the source since it always errors out in ECL and we hardcode the correct path elsewhere anyways. As it stands ECL still suffers from a very weird problem which happens when compiling postmodern and moptilities: https://gitlab.com/embeddable-common-lisp/ecl/-/issues/651 Change-Id: I0285924f92ac154126b4c42145073c3fb33702ed Reviewed-on: https://cl.tvl.fyi/c/depot/+/3297 Tested-by: BuildkiteCI Reviewed-by: tazjin Reviewed-by: eta --- lisp/dns/default.nix | 4 ++++ lisp/klatre/klatre.lisp | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) (limited to 'lisp') diff --git a/lisp/dns/default.nix b/lisp/dns/default.nix index 43e7ea5030b7..cb2445b460c9 100644 --- a/lisp/dns/default.nix +++ b/lisp/dns/default.nix @@ -14,4 +14,8 @@ depot.nix.buildLisp.library { ./message.lisp ./client.lisp ]; + + brokenOn = [ + "ecl" # dynamic cffi + ]; } diff --git a/lisp/klatre/klatre.lisp b/lisp/klatre/klatre.lisp index 0b986ac25125..79c7259752c6 100644 --- a/lisp/klatre/klatre.lisp +++ b/lisp/klatre/klatre.lisp @@ -105,7 +105,8 @@ separated by SEP." "Attempt to parse STR as an integer, returning nil if it is invalid." (check-type str string) (handler-case (parse-integer str) - (sb-int:simple-parse-error (_) (declare (ignore _)) nil))) + (#+sbcl sb-int:simple-parse-error + #-sbcl parse-error (_) (declare (ignore _)) nil))) ;;; ;;; Function utilities -- cgit 1.4.1