From 45afa18846556c3486e6922108ed6e8fcf6ec125 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Wed, 26 Sep 2018 23:19:34 +0200 Subject: feat(postgres): Compatibility with new associated error type MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changes the implementation of action execution to deal with the returned associated errors. The only sensible constraint on those errors that I could think of for now is `Debug`, meaning that errors are now persisted as debug messages. This is not as nice to work with for a future implementation of retryable actions as the equivalent in Haskell, but maybe an idea shows up underway. The main issue is that most of the common error types will not be implementing Serde traits, so serialization to/from the same error type is difficult. Adding an implementation constraint for JSON serialisation on error types (i.e. `S::Error: Serialize + Deserialize`) would probably cause headaches for users, especially if they are trying to use an out-of-the-box error type or an error type wrapping foreign errors. Det ska'kke være lett ... --- finito-postgres/src/tests.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'finito-postgres/src/tests.rs') diff --git a/finito-postgres/src/tests.rs b/finito-postgres/src/tests.rs index 55ada1329143..b1b5821be3c4 100644 --- a/finito-postgres/src/tests.rs +++ b/finito-postgres/src/tests.rs @@ -1,5 +1,5 @@ use super::*; -use finito; + use finito_door::*; use postgres::{Connection, TlsMode}; -- cgit 1.4.1