From 2e63a4e2e1effca4ca605b45a0beb976a0df9dd0 Mon Sep 17 00:00:00 2001 From: William Carroll Date: Mon, 17 Feb 2020 22:35:53 +0000 Subject: Require keybindings.el after wpc-keybindings.el keybindings.el calls (require 'evil-ex), which I introduced in this commit... 0456a1c4b4405da2681296b2250681454637d80f ...calling (require 'evil-ex) loads evil. When evil is loaded before evil-want-integration is set to nil, evil-collection writes to *Warnings* when Emacs initializes, which I find noisy. This commit ensures the evil-want-integration is set to nil before evil is loaded, which appeases evil-collection and thus removes the warning message. Bonus: If you git checkout the previous commit, and attempt to run the KBDs... - `SPC g s`: magit-status - `s h`: evil-window-vsplit ...from a buffer whose major-mode is dired-mode, you should notice that the above functions won't execute. Strangely though, if you look at this commit... 37f8ca04f29ea9bf988b2277c42f3e264d7a89e1 ...I fixed these issues. Well I introduced a regression when I added 0456a1c. My current guess is that when evil-collection complains about evil-want-integration, it is breaking the evaluation sequence of my init.el file. wpc-dired.el is downstream from wpc-keybindings.el, which requires evil-collection. Perhaps no modules required after wpc-keybindings.el are evaluated after evil-collection warns about evil-want-integration. Even if that assumption is wrong, what I do know is that this commit fixes the evil-collection warning and restores the KBDs for dired-mode-map. Here's to feeding two birds with one scone! --- emacs/.emacs.d/init.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'emacs/.emacs.d/init.el') diff --git a/emacs/.emacs.d/init.el b/emacs/.emacs.d/init.el index 91fff6a720bc..fa5147206c17 100644 --- a/emacs/.emacs.d/init.el +++ b/emacs/.emacs.d/init.el @@ -35,8 +35,8 @@ ;; (require 'egg-timer "~/programming/egg-timer.el/egg-timer.el") ;; TODO: Reconcile kbd.el, keybindings.el, wpc-keybindings.el, keyboard.el. -(require 'keybindings) (require 'wpc-keybindings) +(require 'keybindings) (require 'window-manager) (require 'wpc-ui) (require 'wpc-dired) -- cgit 1.4.1