From 01a0d5c82205c0b0677af0f8c60ad5e9ba23ce02 Mon Sep 17 00:00:00 2001
From: Vincent Ambo <mail@tazj.in>
Date: Sun, 4 Sep 2022 21:39:21 +0300
Subject: feat(corp/tvixbolt): implement optional runtime tracing

Uses Tvix's new `TracingObserver` to optionally produce a runtime
trace, which the user can toggle via a checkbox.

Runtime traces can be quite long, so they're only produced if asked
for.

Change-Id: Id0f27dc8ef6e9d81a31ecf22c81757b066815320
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6331
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
---
 corp/tvixbolt/src/main.rs | 34 ++++++++++++++++++++++++++++------
 1 file changed, 28 insertions(+), 6 deletions(-)

(limited to 'corp/tvixbolt/src')

diff --git a/corp/tvixbolt/src/main.rs b/corp/tvixbolt/src/main.rs
index d43241da6333..c4359dc6dc1e 100644
--- a/corp/tvixbolt/src/main.rs
+++ b/corp/tvixbolt/src/main.rs
@@ -1,17 +1,21 @@
 use std::fmt::Write;
 
 use std::rc::Rc;
-use tvix_eval::observer::DisassemblingObserver;
+use tvix_eval::observer::TracingObserver;
+use tvix_eval::observer::{DisassemblingObserver, NoOpObserver};
+use web_sys::HtmlInputElement;
 use web_sys::HtmlTextAreaElement;
 use yew::prelude::*;
 use yew::TargetCast;
 
 enum Msg {
     CodeChange(String),
+    ToggleTrace(bool),
 }
 
 struct Model {
     code: String,
+    trace: bool,
 }
 
 fn tvixbolt_overview() -> Html {
@@ -65,11 +69,17 @@ impl Component for Model {
     fn create(_ctx: &Context<Self>) -> Self {
         Self {
             code: String::new(),
+            trace: false,
         }
     }
 
     fn update(&mut self, _ctx: &Context<Self>, msg: Self::Message) -> bool {
         match msg {
+            Msg::ToggleTrace(trace) => {
+                self.trace = trace;
+                true
+            }
+
             Msg::CodeChange(new_code) => {
                 self.code = new_code;
                 true
@@ -102,8 +112,14 @@ impl Component for Model {
                     </div>
 
                     <div class="form-group">
-                      <label for="disable-bytecode">{"Disassemble:"}</label>
-                      <input for="disable-bytecode" type="checkbox" checked=true disabled=true />
+                      <label for="trace-runtime">{"Trace runtime:"}</label>
+                      <input
+                       for="trace-runtime" type="checkbox" checked={self.trace}
+                       onchange={link.callback(|e: Event| {
+                           let trace = e.target_unchecked_into::<HtmlInputElement>().checked();
+                           Msg::ToggleTrace(trace)
+                       })}
+                       />
                     </div>
                   </fieldset>
                 </form>
@@ -132,7 +148,7 @@ impl Model {
         html! {
             <>
               <h2>{"Result:"}</h2>
-              {eval(&self.code).display()}
+              {eval(self.trace, &self.code).display()}
             </>
         }
     }
@@ -146,6 +162,7 @@ struct Output {
     runtime_errors: String,
     output: String,
     bytecode: Vec<u8>,
+    trace: Vec<u8>,
 }
 
 fn maybe_show(title: &str, s: &str) -> Html {
@@ -171,12 +188,13 @@ impl Output {
             {maybe_show("Bytecode:", &String::from_utf8_lossy(&self.bytecode))}
             {maybe_show("Runtime errors:", &self.runtime_errors)}
             {maybe_show("Output:", &self.output)}
+            {maybe_show("Runtime trace:", &String::from_utf8_lossy(&self.trace))}
             </>
         }
     }
 }
 
-fn eval(code: &str) -> Output {
+fn eval(trace: bool, code: &str) -> Output {
     let mut out = Output::default();
 
     if code.is_empty() {
@@ -241,7 +259,11 @@ fn eval(code: &str) -> Output {
         return out;
     }
 
-    let result = tvix_eval::run_lambda(result.lambda);
+    let result = if trace {
+        tvix_eval::run_lambda(&mut TracingObserver::new(&mut out.trace), result.lambda)
+    } else {
+        tvix_eval::run_lambda(&mut NoOpObserver::default(), result.lambda)
+    };
 
     match result {
         Ok(value) => writeln!(&mut out.output, "{}", value).unwrap(),
-- 
cgit 1.4.1