From b3342afbfa28da3353195e611bd9d19eb6a6c587 Mon Sep 17 00:00:00 2001 From: William Carroll Date: Wed, 11 Dec 2019 10:31:57 +0000 Subject: Temporarily disable code that creates circular deps After attempting to package some of my Elisp libraries using Nix, I exposed circular dependencies between modules that has existed for awhile. I'm temporarily disabling this code since I do not have time to refactor everything. When I get around to packaging everything, I'll need to resolve these issues. For now, I must carry on. --- configs/shared/.emacs.d/wpc/number.el | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) (limited to 'configs/shared/.emacs.d/wpc/number.el') diff --git a/configs/shared/.emacs.d/wpc/number.el b/configs/shared/.emacs.d/wpc/number.el index 81d3c5d2b935..f496349050d9 100644 --- a/configs/shared/.emacs.d/wpc/number.el +++ b/configs/shared/.emacs.d/wpc/number.el @@ -106,16 +106,18 @@ While this function is undeniably trivial, I have unintentionally done (- 1 x) ;; TODO: Does this belong in a math module? Is math too vague? Or is number ;; too vague? -(defun number/factorial (x) - "Return factorial of `X'." - (cond - ((number/negative? x) (error "Will not take factorial of negative numbers")) - ((= 0 x) 1) - ;; NOTE: Using `series/range' introduces a circular dependency because: - ;; series -> number -> series. Conceptually, however, this should be - ;; perfectly acceptable. - (t (->> (series/range 1 x) - (list/reduce 1 #'*))))) +;; TODO: Resolve the circular dependency that this introduces with series.el, +;; and then re-enable this function and its tests below. +;; (defun number/factorial (x) +;; "Return factorial of `X'." +;; (cond +;; ((number/negative? x) (error "Will not take factorial of negative numbers")) +;; ((= 0 x) 1) +;; ;; NOTE: Using `series/range' introduces a circular dependency because: +;; ;; series -> number -> series. Conceptually, however, this should be +;; ;; perfectly acceptable. +;; (t (->> (series/range 1 x) +;; (list/reduce 1 #'*))))) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; Tests @@ -132,8 +134,8 @@ While this function is undeniably trivial, I have unintentionally done (- 1 x) (number/whole? 0)) (prelude/assert (number/integer? 10)) - (prelude/assert - (= 120 (number/factorial 5))) + ;; (prelude/assert + ;; (= 120 (number/factorial 5))) (prelude/assert (number/even? 6)) (prelude/refute -- cgit 1.4.1