From b26569028c5601c8c7a413c006e7f2649d5e0b13 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sun, 12 May 2024 14:35:52 +0300 Subject: feat(tvix/castore/directory/get_recursive): add 'static to BoxStream Necessary to directly use this in the GRPC DirectoryService wrapper directly. Change-Id: Ic6a0038a40dc30071d145af5035345fcd93288ae Reviewed-on: https://cl.tvl.fyi/c/depot/+/11634 Autosubmit: flokli Tested-by: BuildkiteCI Reviewed-by: Connor Brewster --- tvix/castore/src/directoryservice/bigtable.rs | 2 +- tvix/castore/src/directoryservice/grpc.rs | 2 +- tvix/castore/src/directoryservice/memory.rs | 2 +- tvix/castore/src/directoryservice/mod.rs | 4 ++-- tvix/castore/src/directoryservice/sled.rs | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tvix/castore/src/directoryservice/bigtable.rs b/tvix/castore/src/directoryservice/bigtable.rs index 0fdb24628f83..1194c6ddc999 100644 --- a/tvix/castore/src/directoryservice/bigtable.rs +++ b/tvix/castore/src/directoryservice/bigtable.rs @@ -343,7 +343,7 @@ impl DirectoryService for BigtableDirectoryService { fn get_recursive( &self, root_directory_digest: &B3Digest, - ) -> BoxStream> { + ) -> BoxStream<'static, Result> { traverse_directory(self.clone(), root_directory_digest) } diff --git a/tvix/castore/src/directoryservice/grpc.rs b/tvix/castore/src/directoryservice/grpc.rs index 7402fe1b5659..fe935629bfcb 100644 --- a/tvix/castore/src/directoryservice/grpc.rs +++ b/tvix/castore/src/directoryservice/grpc.rs @@ -107,7 +107,7 @@ impl DirectoryService for GRPCDirectoryService { fn get_recursive( &self, root_directory_digest: &B3Digest, - ) -> BoxStream> { + ) -> BoxStream<'static, Result> { let mut grpc_client = self.grpc_client.clone(); let root_directory_digest = root_directory_digest.clone(); diff --git a/tvix/castore/src/directoryservice/memory.rs b/tvix/castore/src/directoryservice/memory.rs index 3d1c5009be9b..3b2795c3968c 100644 --- a/tvix/castore/src/directoryservice/memory.rs +++ b/tvix/castore/src/directoryservice/memory.rs @@ -73,7 +73,7 @@ impl DirectoryService for MemoryDirectoryService { fn get_recursive( &self, root_directory_digest: &B3Digest, - ) -> BoxStream> { + ) -> BoxStream<'static, Result> { traverse_directory(self.clone(), root_directory_digest) } diff --git a/tvix/castore/src/directoryservice/mod.rs b/tvix/castore/src/directoryservice/mod.rs index cf6bea39d809..ca82ff2bc95d 100644 --- a/tvix/castore/src/directoryservice/mod.rs +++ b/tvix/castore/src/directoryservice/mod.rs @@ -64,7 +64,7 @@ pub trait DirectoryService: Send + Sync { fn get_recursive( &self, root_directory_digest: &B3Digest, - ) -> BoxStream>; + ) -> BoxStream<'static, Result>; /// Allows persisting a closure of [proto::Directory], which is a graph of /// connected Directory messages. @@ -87,7 +87,7 @@ where fn get_recursive( &self, root_directory_digest: &B3Digest, - ) -> BoxStream> { + ) -> BoxStream<'static, Result> { self.as_ref().get_recursive(root_directory_digest) } diff --git a/tvix/castore/src/directoryservice/sled.rs b/tvix/castore/src/directoryservice/sled.rs index d531513e1ed7..9490a49c00ae 100644 --- a/tvix/castore/src/directoryservice/sled.rs +++ b/tvix/castore/src/directoryservice/sled.rs @@ -112,7 +112,7 @@ impl DirectoryService for SledDirectoryService { fn get_recursive( &self, root_directory_digest: &B3Digest, - ) -> BoxStream> { + ) -> BoxStream<'static, Result> { traverse_directory(self.clone(), root_directory_digest) } -- cgit 1.4.1