From 807e7ec55f64e52218c27921b580cede6752785a Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Wed, 22 Jun 2022 00:11:28 +0300 Subject: style(3p/cgit): move commit decorations left of subject the commit decoration layout is designed for situations where very few commits have decorations, but every depot commit has a revision. putting these on the left of the commit subject looks a lot more reasonable. ideally we would actually put them in the table as a column, but that'd be a much larger change. Change-Id: I0b44dbef36b64b183d66278d7ab7e4ff17554684 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5892 Tested-by: BuildkiteCI Reviewed-by: Profpatsch --- third_party/cgit/ui-log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/third_party/cgit/ui-log.c b/third_party/cgit/ui-log.c index 6cd258c1cc..520a7496a8 100644 --- a/third_party/cgit/ui-log.c +++ b/third_party/cgit/ui-log.c @@ -252,9 +252,10 @@ static void print_commit(struct commit *commit, struct rev_info *revs) strlcpy(info->subject + i, wrap_symbol, subject_len - i + 1); } } + show_commit_decorations(commit); + html(" "); cgit_commit_link(info->subject, NULL, NULL, ctx.qry.head, oid_to_hex(&commit->object.oid), ctx.qry.vpath); - show_commit_decorations(commit); html(""); cgit_open_filter(ctx.repo->email_filter, info->author_email, "log"); html_txt(info->author); -- cgit 1.4.1