From 4edef59ba48eba53b258223833a36803602d4250 Mon Sep 17 00:00:00 2001
From: sterni <sternenseemann@systemli.org>
Date: Sun, 11 Apr 2021 02:24:21 +0200
Subject: feat(panettone): don't use `_` for em in inline markdown

Since we are still using third_party, underscores are kind of common in
issue titles and are probably often forgotten to escape. Let's just
support `*` for emphasized text in titles for now.

Change-Id: I305bcf4d4c59123bba4ce816a6da2ee8b022c34e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2926
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Reviewed-by: glittershark <grfn@gws.fyi>
---
 web/panettone/src/inline-markdown.lisp       |  1 -
 web/panettone/test/inline-markdown_test.lisp | 10 +++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/web/panettone/src/inline-markdown.lisp b/web/panettone/src/inline-markdown.lisp
index 9948a629b378..fc5f77584fc4 100644
--- a/web/panettone/src/inline-markdown.lisp
+++ b/web/panettone/src/inline-markdown.lisp
@@ -3,7 +3,6 @@
 
 (define-constant +inline-markup-types+
   '(("~~" :del)
-    ("_"  :em)
     ("*"  :em)
     ("`"  :code))
   :test #'equal)
diff --git a/web/panettone/test/inline-markdown_test.lisp b/web/panettone/test/inline-markdown_test.lisp
index 2b6c3b89002c..a32464456d48 100644
--- a/web/panettone/test/inline-markdown_test.lisp
+++ b/web/panettone/test/inline-markdown_test.lisp
@@ -10,12 +10,12 @@
 
 (inline-markdown-unit-test
   inline-markdown-typical-test
-  "hello _world_, here is ~~no~~ `code`!"
+  "hello *world*, here is ~~no~~ `code`!"
   "hello <em>world</em>, here is <del>no</del> <code>code</code>!")
 
 (inline-markdown-unit-test
   inline-markdown-two-emphasize-types-test
-  "_stress_ *this*"
+  "*stress* *this*"
   "<em>stress</em> <em>this</em>")
 
 (inline-markdown-unit-test
@@ -30,8 +30,8 @@
 
 (inline-markdown-unit-test
   inline-markdown-escaping-test
-  "A backslash \\\\ shows: \\*, \\_, \\` and \\~~"
-  "A backslash \\ shows: *, _, ` and ~~")
+  "A backslash \\\\ shows: \\*, \\` and \\~~"
+  "A backslash \\ shows: *, ` and ~~")
 
 (inline-markdown-unit-test
   inline-markdown-nested-escaping-test
@@ -45,7 +45,7 @@
 
 (inline-markdown-unit-test
   inline-markdown-no-unclosed-tags-test
-  "A tag, once opened, _must be closed"
+  "A tag, once opened, *must be closed"
   "A tag, once opened, <em>must be closed</em>")
 
 (inline-markdown-unit-test
-- 
cgit 1.4.1