From 48b0fac76bd1444eac7dd082b699e0ec41fbfdd3 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Fri, 26 Aug 2022 18:47:46 +0300 Subject: refactor(tvix/eval): slightly more readable AttrsRep::select Suggestion from grfn in cl/6158. Change-Id: I16dcf2296a5ec5d299d5a080ca099b8eda6c254e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6278 Reviewed-by: grfn Tested-by: BuildkiteCI --- tvix/eval/src/value/attrs.rs | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/tvix/eval/src/value/attrs.rs b/tvix/eval/src/value/attrs.rs index 74f1bd4481..922aa0c0d3 100644 --- a/tvix/eval/src/value/attrs.rs +++ b/tvix/eval/src/value/attrs.rs @@ -51,17 +51,11 @@ impl AttrsRep { match self { AttrsRep::Empty => None, - AttrsRep::KV { name, value } => { - if key == "name" { - return Some(name); - } - - if key == "value" { - return Some(value); - } - - None - } + AttrsRep::KV { name, value } => match key { + "name" => Some(name), + "value" => Some(value), + _ => None, + }, AttrsRep::Map(map) => map.get(&key.into()), } -- cgit 1.4.1