From 37b0b37771f066775120e8f3932bd68c34d57e8a Mon Sep 17 00:00:00 2001 From: "C. McEnroe" Date: Wed, 18 Dec 2019 21:30:12 +0000 Subject: feat(cgit/ui-blame): bail if blob is binary This avoids piping binary blobs through the source-filter. --- third_party/cgit/ui-blame.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/third_party/cgit/ui-blame.c b/third_party/cgit/ui-blame.c index 45fe191344f3..886c4c19fd1d 100644 --- a/third_party/cgit/ui-blame.c +++ b/third_party/cgit/ui-blame.c @@ -151,6 +151,10 @@ static void print_object(const struct object_id *oid, const char *path, cgit_tree_link("tree", NULL, NULL, ctx.qry.head, rev, path); html(")\n"); + if (buffer_is_binary(buf, size)) { + html("
blob is binary.
"); + goto cleanup; + } if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) { htmlf("
blob size (%ldKB)" " exceeds display size limit (%dKB).
", -- cgit 1.4.1