From 058bf61193f166f34d3dc4b6629a691b70d43142 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Fri, 14 Jan 2022 22:17:25 +0300 Subject: fix(gerrit-tvl): Fix construction of ref used in Buildkite ... and remove a spammy log statement. This changed in besadii a while ago and lead to the behaviour of failing silently, instead of failing with an error saying "undefined undefined". Note that with this change merged the plugin probably still won't work again, but it gets us a step closer to the real error. Change-Id: I3db25d246f4b1c634d316cd92574e27fb220d769 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4887 Autosubmit: tazjin Tested-by: BuildkiteCI Reviewed-by: lukegb --- ops/gerrit-tvl/static/tvl.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ops/gerrit-tvl/static/tvl.js b/ops/gerrit-tvl/static/tvl.js index 470eb79d6689..2f8db90945ed 100644 --- a/ops/gerrit-tvl/static/tvl.js +++ b/ops/gerrit-tvl/static/tvl.js @@ -41,8 +41,8 @@ const tvlChecksProvider = { } const params = { - // besadii uses the patchset ref as the branch name. - branch: `refs/changes/${changeNumber.toString().slice(-2)}/${changeNumber}/${patchsetNumber}`, + // besadii groups different patchsets of the same CL under this fake ref + branch: `cl/${changeNumber.toString()}`, }; const url = `https://api.buildkite.com/v2/organizations/tvl/pipelines/depot/builds?${encodeParams(params)}`; const resp = await fetch(url, { @@ -115,7 +115,6 @@ const tvlChecksProvider = { checkRun.results = [result]; } - console.log(checkRun); runs.push(checkRun); } } -- cgit 1.4.1