about summary refs log tree commit diff
path: root/third_party/gerrit_plugins/code-owners/default.nix
AgeCommit message (Collapse)AuthorFilesLines
2024-07-08 r/8358 chore(3p/gerrit): create buildBazelPackageNG and migrate gerrit to itLuke Granger-Brown1-3/+3
This bumps Gerrit to 3.10.0, and also introduces a new mechanism for building it that should hopefully have some more stable hashes than the previous bodgery. In this world, we only cache what we explicitly want to. There are some hooks implemented for `rules_java` and `rules_nodejs` (before version 6) that force use of local binaries; this means we can drop the use of the FHSUserEnv and use the java and nodejs binaries provided by nixpkgs instead. detzip is deleted; it hasn't been used in yonks. We also add https://gerrit-review.googlesource.com/c/gerrit/+/431977, which bumps the SSHd version so that we can have U2F-based SSH keys. Change-Id: Ie12a9a33bbb1e4bd96aa252580aca3b8bc4a1205 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11963 Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2024-02-12 r/7503 chore(3p/gerrit): 3.8.2 -> 3.9.1Luke Granger-Brown1-1/+1
Change-Id: I8fa10b52c44bd3d5efb0fff740ad6d5da6e96831 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10802 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2023-10-16 r/6821 chore(3p/gerrit): 3.7.0-rc4 -> 3.8.2Luke Granger-Brown1-3/+3
Bump gerrit plugins dep hashes, and for code-owners rebase it against master. Change-Id: If7da0ca391b4a5c0102560ca8d52b6f5a2dfd223 Reviewed-on: https://cl.tvl.fyi/c/depot/+/9734 Autosubmit: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2023-04-26 r/6112 chore(3p/sources): Bump channels & overlayssterni1-1/+1
* //3p/sources: Note that emacs-overlay is not updated for now, as changes in emacs HEAD break //users/sterni/emacs. * //3p/gerrit_plugins/code-owners: deps hash changed once again or was no longer in the Nix store. Unfortunately, building the deps derivations from scratch for gerrit and the gerrit plugins no longer works due to a nixpkgs regression: Due to a (operator precedence) mistake in the way the deps derivation's installPhase is computed, it would append extra code to the installPhase provided by us, causing a bash syntax error. I have proposed a fix for this upstream (<https://github.com/NixOS/nixpkgs/pull/228305>). Adding a workaround in the repo would be possible, but a bit annoying. Since the derivations are fixed output anyways, I've opted to build the missing deps derivation (for code-owners) locally using the fixed nixpkgs, updated the sha256 and copied the result into whitby's Nix store. Hopefully by the next time we'll be rebuilding the deps derivations again the fix will have propagated into the NixOS unstable channel. * //users/grfn/system/system:roswellSystem: Use mysql80 from stable. See also https://github.com/NixOS/nixpkgs/issues/226673. Change-Id: I9b9d57f589be4cdc3fd4f39729c170a25a655b74 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8483 Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2023-04-09 r/6087 chore(3p/sources): Bump channels & overlayssterni1-1/+1
* //3p/gerrit{,_plugins}: adjust for API change to buildBazelPackage https://github.com/NixOS/nixpkgs/commit/440b4de588d950e7fcf7add3b049fb209f097367 * //3p/gerrit_plugins: update hash of deps jar Change-Id: I131d5846acbce718126fb47671893a568d1020dd Reviewed-on: https://cl.tvl.fyi/c/depot/+/8445 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-11-06 r/5257 chore(gerrit): bump to 3.7.0-rc4Luke Granger-Brown1-1/+1
Change-Id: Ib6f4fd5817fb5415cff5ea1d8c75c8c9a08d56b4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7185 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-09-19 r/4921 feat(gerrit): add code-owners pluginLuke Granger-Brown1-0/+17
This is the New Thing that is intended to replace the find-owners and owners plugins. In particular: * It inserts a submit requirement rather than providing a Prolog predicate. * The default OWNERS file formats are suspiciously Googley. * It provides a neat UI for finding OWNERS and tracking approval state on a per-file basis. When we fully migrate to using the code-owners plugin, a few things will need to land, which I will likely do "offline" directly to the Gerrit backing Git repos: * Add the corresponding Gerrit config * Replace OWNERS files depot-wide * Add OWNERS files to the refs/meta/config branch * Introduce the Owners-Override label, settable by depot-interventions The enclosed patch adds two extra pieces of functionality that we need in tvldepot but aren't upstream: 1. The ability to just specify usernames rather than email addresses 2. The ability to specify `group:GROUPNAME`, _as long as_ that group is visible to everyone. This is a restriction intended to avoid having the plugin just leak group membership. Change-Id: I27d92b6cb7449af83030b9015f09a1571aa8452f Reviewed-on: https://cl.tvl.fyi/c/depot/+/6664 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org>