depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2017-09-14	RemoteStore: Add option to drop old connections from the pool	Eelco Dolstra	1	-0/+6
	This is a hack to make hydra-queue-runner free its temproots periodically, thereby ensuring that garbage collection of the corresponding paths is not blocked until the queue runner is restarted. It would be better if temproots could be released earlier than at process exit. I started working on a RAII object returned by functions like addToStore() that releases temproots. However, this would be a pretty massive change so I gave up on it for now.
2017-07-03	Replace a few bool flags with enums	Eelco Dolstra	1	-5/+6
	Functions like copyClosure() had 3 bool arguments, which creates a severe risk of mixing up arguments. Also, implement copyClosure() using copyPaths().
2017-05-02	build-remote: Fix fallback to other machines when connecting fails	Eelco Dolstra	1	-0/+2
	Opening an SSHStore or LegacySSHStore does not actually establish a connection, so the try/catch block here did nothing. Added a Store::connect() method to test whether a connection can be established.
2017-04-13	Add a Config class to simplify adding configuration settings	Eelco Dolstra	1	-0/+3
	The typical use is to inherit Config and add Setting<T> members: class MyClass : private Config { Setting<int> foo{this, 123, "foo", "the number of foos to use"}; Setting<std::string> bar{this, "blabla", "bar", "the name of the bar"}; MyClass() : Config(readConfigFile("/etc/my-app.conf")) { std::cout << foo << "\n"; // will print 123 unless overriden } }; Currently, this is used by Store and its subclasses for store parameters. You now get a warning if you specify a non-existant store parameter in a store URI.
2017-04-06	Implement RemoteStore::queryMissing()	Eelco Dolstra	1	-0/+4
	This provides a significant speedup, e.g. 64 s -> 12 s for nix-build --dry-run -I nixpkgs=channel:nixos-16.03 '<nixpkgs/nixos/tests/misc.nix>' -A test on a cold local and CloudFront cache. The alternative is to use lots of concurrent daemon connections but that seems wasteful.
2017-03-16	copyPaths(): Use queryValidPaths() to reduce SSH latency	Eelco Dolstra	1	-1/+1

2017-03-03	Cache connection failures	Eelco Dolstra	1	-0/+4

2017-03-03	Improve SSH handling	Eelco Dolstra	1	-2/+2
	* Unify SSH code in SSHStore and LegacySSHStore. * Fix a race starting the SSH master. We now wait synchronously for the SSH master to finish starting. This prevents the SSH clients from starting their own connections. * Don't use a master if max-connections == 1. * Add a "max-connections" store parameter. * Add a "compress" store parameter.
2016-11-09	Merge branch 'ssh-store' of https://github.com/shlevy/nix	Eelco Dolstra	1	-8/+27

2016-10-21	Remove addPathToAccessor	Eelco Dolstra	1	-1/+2

2016-10-21	BinaryCacheStore: Optionally write a NAR listing	Eelco Dolstra	1	-1/+1
	The store parameter "write-nar-listing=1" will cause BinaryCacheStore to write a file ‘<store-hash>.ls.xz’ for each ‘<store-hash>.narinfo’ added to the binary cache. This file contains an XZ-compressed JSON file describing the contents of the NAR, excluding the contents of regular files. E.g. { "version": 1, "root": { "type": "directory", "entries": { "lib": { "type": "directory", "entries": { "Mcrt1.o": { "type": "regular", "size": 1288 }, "Scrt1.o": { "type": "regular", "size": 3920 }, } } } ... } } (The actual file has no indentation.) This is intended to speed up the NixOS channels programs index generator [1], since fetching gazillions of large NARs from cache.nixos.org is currently a bottleneck for updating the regular (non-small) channel. [1] https://github.com/NixOS/nixos-channel-scripts/blob/master/generate-programs-index.cc
2016-09-16	Make computeFSClosure() single-threaded again	Eelco Dolstra	1	-1/+3
	The fact that queryPathInfo() is synchronous meant that we needed a thread for every concurrent binary cache lookup, even though they end up being handled by the same download thread. Requiring hundreds of threads is not a good idea. So now there is an asynchronous version of queryPathInfo() that takes a callback function to process the result. Similarly, enqueueDownload() now takes a callback rather than returning a future. Thus, a command like nix path-info --store https://cache.nixos.org/ -r /nix/store/slljrzwmpygy1daay14kjszsr9xix063-nixos-16.09beta231.dccf8c5 that returns 4941 paths now takes 1.87s using only 2 threads (the main thread and the downloader thread). (This is with a prewarmed CloudFront.)
2016-09-02	Add ssh store implementation	Shea Levy	1	-4/+4

2016-09-02	Factor out the unix domain socket-specific code from RemoteStore	Shea Levy	1	-7/+26

2016-06-01	Make the store directory a member variable of Store	Eelco Dolstra	1	-1/+1

2016-05-31	nix-copy-closure / build-remote.pl: Disable signature checking	Eelco Dolstra	1	-1/+1
	This restores the Nix 1.11 behaviour.
2016-05-04	Add a Store::addToStore() variant that accepts a NAR	Eelco Dolstra	1	-5/+3
	As a side effect, this ensures that signatures are propagated when copying paths between stores. Also refactored import/export to make use of this.
2016-05-04	Remove OpenSSL-based signing	Eelco Dolstra	1	-3/+2

2016-04-29	Allow parameters in store URIs	Eelco Dolstra	1	-0/+2
	This is to allow store-specific configuration, e.g. s3://my-cache?compression=bzip2&secret-key=/path/to/key.
2016-04-19	Move path info caching from BinaryCacheStore to Store	Eelco Dolstra	1	-8/+2
	Caching path info is generally useful. For instance, it speeds up "nix path-info -rS /run/current-system" (i.e. showing the closure sizes of all paths in the closure of the current system) from 5.6s to 0.15s. This also eliminates some APIs like Store::queryDeriver() and Store::queryReferences().
2016-04-08	Remove failed build caching	Eelco Dolstra	1	-4/+0
	This feature was implemented for Hydra, but Hydra no longer uses it.
2016-04-05	Add "nix copy-sigs" command	Eelco Dolstra	1	-0/+2
	This imports signatures from one store into another. E.g. $ nix copy-sigs -r /run/current-system -s https://cache.nixos.org/ imported 595 signatures
2016-02-26	importPaths(): Optionally add NARs to binary cache accessor	Eelco Dolstra	1	-1/+2
	This enables an optimisation in hydra-queue-runner, preventing a download of a NAR it just uploaded to the cache when reading files like hydra-build-products.
2016-02-25	Add NAR / Store accessor abstraction	Eelco Dolstra	1	-1/+3
	This is primary to allow hydra-queue-runner to extract files like "nix-support/hydra-build-products" from NARs in binary caches.
2016-02-24	Eliminate reserveSpace flag	Eelco Dolstra	1	-1/+1

2016-02-23	Pool<T>: Allow a maximum pool size	Eelco Dolstra	1	-3/+4

2016-02-23	RemoteStore: Make thread-safe	Eelco Dolstra	1	-9/+13
	This allows a RemoteStore object to be used safely from multiple threads concurrently. It will make multiple daemon connections if necessary. Note: pool.hh and sync.hh have been copied from the Hydra source tree.
2016-02-04	StoreAPI -> Store	Eelco Dolstra	1	-1/+1
	Calling a class an API is a bit redundant...
2015-09-18	Shut up clang warnings	Eelco Dolstra	1	-29/+30

2015-07-17	Allow remote builds without sending the derivation closure	Eelco Dolstra	1	-0/+3
	Previously, to build a derivation remotely, we had to copy the entire closure of the .drv file to the remote machine, even though we only need the top-level derivation. This is very wasteful: the closure can contain thousands of store paths, and in some Hydra use cases, include source paths that are very large (e.g. Git/Mercurial checkouts). So now there is a new operation, StoreAPI::buildDerivation(), that performs a build from an in-memory representation of a derivation (BasicDerivation) rather than from a on-disk .drv file. The only files that need to be in the Nix store are the sources of the derivation (drv.inputSrcs), and the needed output paths of the dependencies (as described by drv.inputDrvs). "nix-store --serve" exposes this interface. Note that this is a privileged operation, because you can construct a derivation that builds any store path whatsoever. Fixing this will require changing the hashing scheme (i.e., the output paths should be computed from the other fields in BasicDerivation, allowing them to be verified without access to other derivations). However, this would be quite nice because it would allow .drv-free building (e.g. "nix-env -i" wouldn't have to write any .drv files to disk). Fixes #173.
2015-06-02	Add a ‘verifyStore’ RPC	Ludovic Courtès	1	-0/+1
	Hello! The patch below adds a ‘verifyStore’ RPC with the same signature as the current LocalStore::verifyStore method. Thanks, Ludo’. >From aef46c03ca77eb6344f4892672eb6d9d06432041 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= <ludo@gnu.org> Date: Mon, 1 Jun 2015 23:17:10 +0200 Subject: [PATCH] Add a 'verifyStore' remote procedure call.
2015-03-25	addToStore(): Take explicit name argument	Eelco Dolstra	1	-14/+14

2014-09-01	Add an 'optimiseStore' remote procedure call.	Ludovic Courtès	1	-1/+3

2014-07-23	Remove dead code	Eelco Dolstra	1	-1/+0

2014-02-18	Add a flag ‘--check’ to verify build determinism	Eelco Dolstra	1	-1/+1
	The flag ‘--check’ to ‘nix-store -r’ or ‘nix-build’ will cause Nix to redo the build of a derivation whose output paths are already valid. If the new output differs from the original output, an error is printed. This makes it easier to test if a build is deterministic. (Obviously this cannot catch all sources of non-determinism, but it catches the most common one, namely the current time.) For example: $ nix-build '<nixpkgs>' -A patchelf ... $ nix-build '<nixpkgs>' -A patchelf --check error: derivation `/nix/store/1ipvxsdnbhl1rw6siz6x92s7sc8nwkkb-patchelf-0.6' may not be deterministic: hash mismatch in output `/nix/store/4pc1dmw5xkwmc6q3gdc9i5nbjl4dkjpp-patchelf-0.6.drv' The --check build fails if not all outputs are valid. Thus the first call to nix-build is necessary to ensure that all outputs are valid. The current outputs are left untouched: the new outputs are either put in a chroot or diverted to a different location in the store using hash rewriting.
2012-12-20	nix-store -q --roots: Respect the gc-keep-outputs/gc-keep-derivations settings	Eelco Dolstra	1	-0/+2
	So if a path is not garbage solely because it's reachable from a root due to the gc-keep-outputs or gc-keep-derivations settings, ‘nix-store -q --roots’ now shows that root.
2012-11-09	Remove definition of non-existant function	Eelco Dolstra	1	-2/+0

2012-10-03	Add a ‘--repair’ flag to nix-instantiate	Eelco Dolstra	1	-2/+2
	This allows repairing corrupted derivations and other source files.
2012-10-02	Add a --repair flag to ‘nix-store -r’ to repair derivation outputs	Eelco Dolstra	1	-1/+1
	With this flag, if any valid derivation output is missing or corrupt, it will be recreated by using a substitute if available, or by rebuilding the derivation. The latter may use hash rewriting if chroots are not available.
2012-07-26	Merge branch 'master' into no-manifests	Eelco Dolstra	1	-5/+1

2012-07-18	Use "#pragma once" to prevent repeated header file inclusion	Eelco Dolstra	1	-5/+1

2012-07-18	Merge branch 'master' into no-manifests	Eelco Dolstra	1	-0/+2

2012-07-17	Add function queryPathFromHashPart()	Eelco Dolstra	1	-0/+2
	To implement binary caches efficiently, Hydra needs to be able to map the hash part of a store path (e.g. "gbg...zr7") to the full store path (e.g. "/nix/store/gbg...kzr7-subversion-1.7.5"). (The binary cache mechanism uses hash parts as a key for looking up store paths to ensure privacy.) However, doing a search in the Nix store for /nix/store/<hash>* is expensive since it requires reading the entire directory. queryPathFromHashPart() prevents this by doing a cheap database lookup.
2012-07-11	Replace hasSubstitutes() with querySubstitutablePaths()	Eelco Dolstra	1	-1/+1
	querySubstitutablePaths() takes a set of paths, so this greatly reduces daemon <-> client latency.
2012-07-11	Add a function queryValidPaths()	Eelco Dolstra	1	-0/+2
	queryValidPaths() combines multiple calls to isValidPath() in one. This matters when using the Nix daemon because it reduces latency. For instance, on "nix-env -qas \*" it reduces execution time from 5.7s to 4.7s (which is indistinguishable from the non-daemon case).
2012-07-11	Rename queryValidPaths() to queryAllValidPaths()	Eelco Dolstra	1	-1/+1

2012-07-11	Implement querySubstitutablePathInfos() in the daemon	Eelco Dolstra	1	-3/+0
	Also removed querySubstitutablePathInfo().
2012-07-06	download-from-binary-cache: parallelise fetching of NAR info files	Eelco Dolstra	1	-0/+3
	Getting substitute information using the binary cache substituter has non-trivial latency overhead. A package or NixOS system configuration can have hundreds of dependencies, and in the worst case (when the local info cache is empty) we have to do a separate HTTP request for each of these. If the ping time to the server is t, getting N info files will take tN seconds; e.g., with a ping time of 0.1s to nixos.org, sequentially downloading 1000 info files (a typical NixOS config) will take at least 100 seconds. To fix this problem, the binary cache substituter can now perform requests in parallel. This required changing the substituter interface to support a function querySubstitutablePathInfos() that queries multiple paths at the same time, and rewriting queryMissing() to take advantage of parallelism. (Due to local caching, parallelising queryMissing() is sufficient for most use cases, since it's almost always called before building a derivation and thus fills the local info cache.) For example, parallelism speeds up querying all 1056 paths in a particular NixOS system configuration from 116s to 2.6s. It works so well because the eccentricity of the top-level derivation in the dependency graph is only 9. So we only need 10 round-trips (when using an unlimited number of parallel connections) to get everything. Currently we do a maximum of 150 parallel connections to the server. Thus it's important that the binary cache server (e.g. nixos.org) has a high connection limit. Alternatively we could use HTTP pipelining, but WWW::Curl doesn't support it and libcurl has a hard-coded limit of 5 requests per pipeline.
2012-06-27	nix-store -r: do substitutions in parallel	Eelco Dolstra	1	-1/+1
	I.e. when multiple non-derivation arguments are passed to ‘nix-store -r’ to be substituted, do them in parallel.
2012-05-29	Reserve some disk space for the garbage collector	Eelco Dolstra	1	-1/+1
	We can't open a SQLite database if the disk is full. Since this prevents the garbage collector from running when it's most needed, we reserve some dummy space that we can free just before doing a garbage collection. This actually revives some old code from the Berkeley DB days. Fixes #27.